Re: [PATCH 2/2] Add support for the CSS list-style-type property

Pedro Worcel <[email protected]> Wed, 3 Apr 2013 20:41:26 +1300
Newsgroups	gmane.comp.web.links
Message-ID	<CAPS+U9_=mbFbyym0gOJO0Zfd4qxSK3=j4Ee3XjnWz2Ao1xNVeQ@mail.gmail.com>
--===============0014064487==
Content-Type: multipart/alternative; boundary=bcaec55244149a06de04d96ffd19

--bcaec55244149a06de04d96ffd19
Content-Type: text/plain; charset=UTF-8

That seems pretty rad! :D


2013/4/3 Fabienne Ducroquet <[email protected]>

> Use the same functions as for the list-style property since only the
> "type" part
> of the list-style property is supported at this stage.
>
> Signed-off-by: Fabienne Ducroquet <[email protected]>
> ---
>  src/document/css/apply.c    |    1 +
>  src/document/css/property.c |    1 +
>  src/document/css/property.h |    1 +
>  src/document/dom/util.c     |    1 +
>  4 files changed, 4 insertions(+)
>
> diff --git a/src/document/css/apply.c b/src/document/css/apply.c
> index 8c3bd85..f94b481 100644
> --- a/src/document/css/apply.c
> +++ b/src/document/css/apply.c
> @@ -149,6 +149,7 @@ static const css_applier_T css_appliers[CSS_PT_LAST] =
> {
>         /* CSS_PT_FONT_STYLE */         css_apply_font_attribute,
>         /* CSS_PT_FONT_WEIGHT */        css_apply_font_attribute,
>         /* CSS_PT_LIST_STYLE */         css_apply_list_style,
> +       /* CSS_PT_LIST_STYLE_TYPE */    css_apply_list_style,
>         /* CSS_PT_TEXT_ALIGN */         css_apply_text_align,
>         /* CSS_PT_TEXT_DECORATION */    css_apply_font_attribute,
>         /* CSS_PT_WHITE_SPACE */        css_apply_font_attribute,
> diff --git a/src/document/css/property.c b/src/document/css/property.c
> index 3914fd1..570aeea 100644
> --- a/src/document/css/property.c
> +++ b/src/document/css/property.c
> @@ -23,6 +23,7 @@ struct css_property_info css_property_info[CSS_PT_LAST]
> = {
>         { "font-style",         CSS_PT_FONT_STYLE,
> CSS_VT_FONT_ATTRIBUTE, css_parse_font_style_value },
>         { "font-weight",        CSS_PT_FONT_WEIGHT,
>  CSS_VT_FONT_ATTRIBUTE, css_parse_font_weight_value },
>         { "list-style",         CSS_PT_LIST_STYLE,
> CSS_VT_LIST_STYLE,     css_parse_list_style_value },
> +       { "list-style-type",    CSS_PT_LIST_STYLE_TYPE,
>  CSS_VT_LIST_STYLE,     css_parse_list_style_value },
>         { "text-align",         CSS_PT_TEXT_ALIGN,
> CSS_VT_TEXT_ALIGN,     css_parse_text_align_value },
>         { "text-decoration",    CSS_PT_TEXT_DECORATION,
>  CSS_VT_FONT_ATTRIBUTE, css_parse_text_decoration_value },
>         { "white-space",        CSS_PT_WHITE_SPACE,
>  CSS_VT_FONT_ATTRIBUTE, css_parse_white_space_value },
> diff --git a/src/document/css/property.h b/src/document/css/property.h
> index 3d96e66..9176624 100644
> --- a/src/document/css/property.h
> +++ b/src/document/css/property.h
> @@ -25,6 +25,7 @@ struct css_property {
>                 CSS_PT_FONT_STYLE,
>                 CSS_PT_FONT_WEIGHT,
>                 CSS_PT_LIST_STYLE,
> +               CSS_PT_LIST_STYLE_TYPE,
>                 CSS_PT_TEXT_ALIGN,
>                 CSS_PT_TEXT_DECORATION,
>                 CSS_PT_WHITE_SPACE,
> diff --git a/src/document/dom/util.c b/src/document/dom/util.c
> index fe03df7..a083a8b 100644
> --- a/src/document/dom/util.c
> +++ b/src/document/dom/util.c
> @@ -63,6 +63,7 @@ init_template_by_style(struct screen_char *template,
> struct document_options *op
>                         case CSS_PT_DISPLAY:
>                         case CSS_PT_NONE:
>                         case CSS_PT_LIST_STYLE:
> +                       case CSS_PT_LIST_STYLE_TYPE:
>                         case CSS_PT_TEXT_ALIGN:
>                         case CSS_PT_WHITE_SPACE:
>                         case CSS_PT_LAST:
> --
> 1.7.10.4
>
> _______________________________________________
> elinks-dev mailing list
> [email protected]
> http://linuxfromscratch.org/mailman/listinfo/elinks-dev
>



-- 
GPG: http://is.gd/droope <http://is.gd/signature_>

--bcaec55244149a06de04d96ffd19
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif">That seems pretty rad! :D<br></div></div><div class=3D"gmail_ex=
tra"><br><br><div class=3D"gmail_quote">2013/4/3 Fabienne Ducroquet <span d=
ir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_blank">fabid=
[email protected]</a>&gt;</span><br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Use the same functions as for the list-style=
 property since only the &quot;type&quot; part<br>
of the list-style property is supported at this stage.<br>
<br>
Signed-off-by: Fabienne Ducroquet &lt;<a href=3D"mailto:[email protected]">=
[email protected]</a>&gt;<br>
---<br>
=C2=A0src/document/css/apply.c =C2=A0 =C2=A0| =C2=A0 =C2=A01 +<br>
=C2=A0src/document/css/property.c | =C2=A0 =C2=A01 +<br>
=C2=A0src/document/css/property.h | =C2=A0 =C2=A01 +<br>
=C2=A0src/document/dom/util.c =C2=A0 =C2=A0 | =C2=A0 =C2=A01 +<br>
=C2=A04 files changed, 4 insertions(+)<br>
<br>
diff --git a/src/document/css/apply.c b/src/document/css/apply.c<br>
index 8c3bd85..f94b481 100644<br>
--- a/src/document/css/apply.c<br>
+++ b/src/document/css/apply.c<br>
@@ -149,6 +149,7 @@ static const css_applier_T css_appliers[CSS_PT_LAST] =
=3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_FONT_STYLE */ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 css_apply_font_attribute,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_FONT_WEIGHT */ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0css_apply_font_attribute,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_LIST_STYLE */ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 css_apply_list_style,<br>
+ =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_LIST_STYLE_TYPE */ =C2=A0 =C2=A0css_apply_=
list_style,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_TEXT_ALIGN */ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 css_apply_text_align,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_TEXT_DECORATION */ =C2=A0 =C2=A0css_a=
pply_font_attribute,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* CSS_PT_WHITE_SPACE */ =C2=A0 =C2=A0 =C2=A0 =
=C2=A0css_apply_font_attribute,<br>
diff --git a/src/document/css/property.c b/src/document/css/property.c<br>
index 3914fd1..570aeea 100644<br>
--- a/src/document/css/property.c<br>
+++ b/src/document/css/property.c<br>
@@ -23,6 +23,7 @@ struct css_property_info css_property_info[CSS_PT_LAST] =
=3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;font-style&quot;, =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 CSS_PT_FONT_STYLE, =C2=A0 =C2=A0 =C2=A0 CSS_VT_FONT_ATTRIBUTE, css_p=
arse_font_style_value },<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;font-weight&quot;, =C2=A0 =C2=A0 =C2=A0=
 =C2=A0CSS_PT_FONT_WEIGHT, =C2=A0 =C2=A0 =C2=A0CSS_VT_FONT_ATTRIBUTE, css_p=
arse_font_weight_value },<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;list-style&quot;, =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 CSS_PT_LIST_STYLE, =C2=A0 =C2=A0 =C2=A0 CSS_VT_LIST_STYLE, =C2=A0 =
=C2=A0 css_parse_list_style_value },<br>
+ =C2=A0 =C2=A0 =C2=A0 { &quot;list-style-type&quot;, =C2=A0 =C2=A0CSS_PT_L=
IST_STYLE_TYPE, =C2=A0CSS_VT_LIST_STYLE, =C2=A0 =C2=A0 css_parse_list_style=
_value },<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;text-align&quot;, =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 CSS_PT_TEXT_ALIGN, =C2=A0 =C2=A0 =C2=A0 CSS_VT_TEXT_ALIGN, =C2=A0 =
=C2=A0 css_parse_text_align_value },<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;text-decoration&quot;, =C2=A0 =C2=A0CSS=
_PT_TEXT_DECORATION, =C2=A0CSS_VT_FONT_ATTRIBUTE, css_parse_text_decoration=
_value },<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 { &quot;white-space&quot;, =C2=A0 =C2=A0 =C2=A0=
 =C2=A0CSS_PT_WHITE_SPACE, =C2=A0 =C2=A0 =C2=A0CSS_VT_FONT_ATTRIBUTE, css_p=
arse_white_space_value },<br>
diff --git a/src/document/css/property.h b/src/document/css/property.h<br>
index 3d96e66..9176624 100644<br>
--- a/src/document/css/property.h<br>
+++ b/src/document/css/property.h<br>
@@ -25,6 +25,7 @@ struct css_property {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_FONT_STYLE,<=
br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_FONT_WEIGHT,=
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_LIST_STYLE,<=
br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_LIST_STYLE_TYPE,<=
br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_TEXT_ALIGN,<=
br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_TEXT_DECORAT=
ION,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CSS_PT_WHITE_SPACE,=
<br>
diff --git a/src/document/dom/util.c b/src/document/dom/util.c<br>
index fe03df7..a083a8b 100644<br>
--- a/src/document/dom/util.c<br>
+++ b/src/document/dom/util.c<br>
@@ -63,6 +63,7 @@ init_template_by_style(struct screen_char *template, stru=
ct document_options *op<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_DISPLAY:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_NONE:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_LIST_STYLE:<br>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 case CSS_PT_LIST_STYLE_TYPE:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_TEXT_ALIGN:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_WHITE_SPACE:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 case CSS_PT_LAST:<br>
<span class=3D"HOEnZb"><font color=3D"#888888">--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
elinks-dev mailing list<br>
<a href=3D"mailto:[email protected]">elinks-dev@linuxfromscra=
tch.org</a><br>
<a href=3D"http://linuxfromscratch.org/mailman/listinfo/elinks-dev" target=
=3D"_blank">http://linuxfromscratch.org/mailman/listinfo/elinks-dev</a><br>
</font></span></blockquote></div><br><br clear=3D"all"><br>-- <br><div dir=
=3D"ltr"><div>GPG:=C2=A0<a href=3D"http://is.gd/signature_" target=3D"_blan=
k">http://is.gd/droope</a><br></div></div>
</div>

--bcaec55244149a06de04d96ffd19--

--===============0014064487==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

--===============0014064487==--