Re: Display of some multi-line links is cut off in the middle

Thomas Dickey <[email protected]> Fri, 31 Dec 2021 20:02:00 -0500

Newsgroups	gmane.comp.web.lynx.devel
Message-ID	<[email protected]>

On Fri, Dec 31, 2021 at 12:23:43PM +0900, KIHARA Hideto wrote:
> * Problem:
> In lynx2.9.0dev.10, display of some multi-line links is cut off in the middle.
> lynx2.9.0dev.9 does not have the problem.
> 
> * Actual Result:
> lynx https://lists.nongnu.org/archive/html/lynx-dev/2021-10/threads.html
> 
> >     * [13][Lynx-dev] Build failures on hppa architectures after update
> >       fr
> 
> * Expected Result:
> >     * [13][Lynx-dev] Build failures on hppa architectures after update
> >       from 2.9.0dev.9 to 2.9.0dev.10, Axel Beckert, 2021/10/30
> 
> * Fix:
> Reverting following change solves the problem.
> --- lynx2.9.0dev.9/src/GridText.c	2021-06-30 07:01:12.000000000 +0900
> +++ lynx2.9.0dev.10/src/GridText.c	2021-10-25 01:13:59.000000000 +0900
> @@ -3006,7 +3005,7 @@
>  	    ctrl_chars_on_this_line += utfxtra_on_this_line;
>  
>  	    /* Add the data to the new line. -FM */
> -	    strcat(linedata, p);
> +	    for (i = 0; (linedata[i] = p[i]) != '\0'; ++i) ;
>  	    line->size = (unsigned short) (line->size + plen);
>  	}
>      }

asan2 reported that this line had a strcpy whose source/destination overlapped.

If you have a test-file which shows the difference, I can probably make
a better fix.

-- 
Thomas E. Dickey <[email protected]>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc (application/pgp-signature, 659 B)