Re: [Fwd: [Mason] patch for task 294: support exec/subexec("comp:method")]

Alex Robinson wrote:
>> I am ready to do what it takes to get this included...
>
> Why not subclass Mason instead? Stick it on CPAN under MasonX and if 
> people start clamouring for the features you provide to be rolled into 
> the core functionality, that's the point at which to talk about 
> including it.
> 
> Indeed, why include your new, largely untested thingamijob, instead of 
> any of the pre-existing MasonX modules, or indeed plugins?

I would have subclassed, but the existing implementation is not simply
designed for that purpose. The function is fairly monolithic and would
require large chunks of copied code. That's just not correct.

If I factor out those chunks of code that I patched into new helper
functions, then yes, I could subclass and be happy. Such changes would
be more disruptive than what I have proposed, but this would be an
acceptable solution for me.

Moreover, I would have assumed that a refactoring would likely be
rejected without this broader perspective of its applicability. Besides,
I am still concerned about fundamental correctness. Until I know that
this kind of thing is even possible to do correctly, there is absolutely
no point in taking the time to munge the patch into a form that will be
merged.

Further. this was listed as TODO on the main mason wiki; if that feature
is not meant to be included in the main package, then it probably should
not be listed there. It gives people like me the wrong impression that
such a contribution would be welcome. If this same feature had not
already been listed there, I would not have even contacted the list.

So that's "why not". ;)

Cheers,

Zach


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642