Re: possible bug in Mason 1.36

On Thu, 23 Aug 2007, Scott Lanning wrote:

> Well, it seems like a Mason bug to me.
>
> The handling of whether or not headers have been sent appears to be 
> broken in Mason, or at least sprained. Presumably that needs cleaned up. 
> I pointed out the two different ways that Mason is checking whether 
> headers have been sent: sometimes with a $sent_headers variable, 
> sometimes with a questionable http_header_sent function.

There's a couple things going on here, I think.

First, I don't know that I entirely understand how this bug manifests, and 
in particular I don't know why the changes from 1.35 to 1.36 would cause 
it. Specifically, why would setting $r->content_type to '' instead of 
undef be the trigger? Mason's (potentially broken) code to determine 
whether headers were sent should work the same way in both of those cases.

That said, looking closely at how we determine if headers were sent, it 
does seem pretty bogus, and I'd like to clean it up.

However, _before_ I do that I'd love to have a test case that demonstrates 
the current bug.


-dave

/*===================================================
VegGuide.Org                        www.BookIRead.com
Your guide to all that's veg.       My book blog
===================================================*/

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/