Re: Need a contractor for HTML::Mason::Critic work
"C.J. Adams-Collier" <[email protected]> Sun, 14 Oct 2007 07:51:13 -0700
| Newsgroups | gmane.comp.web.mason.devel |
|---|---|
| Message-ID | <[email protected]> |
On 10/13/07, Dave Rolsky <[email protected]> wrote: > > > Well, I'm not really up to contributing dev time to this ATM, but I have > some ideas about how it could work. > > I suspect the best way to implement it would be to start by subclassing > Mason's current ToObject compiler. You can override methods in there to > check for Mason-specific things that might be bad. For example, this would > be a good spot to check for abuse of <%perl> blocks (maybe too long, too > many, any at all, etc). > > Then let the superclass do its thing and generate a compiled component, > which is pure Perl. At this point, you can run Perl::Critic against the > compiled code to find other problems, like conditional declarations ("my > $foo if ..."). > > If you're looking for ideas of Mason-specific policies to implement, I'm > sure I could come up with some. > > > -dave Thanks Dave, This all sounds great. Any help you can offer would be appreciated. In particular, Mason-specific policies would be good. I've got some written up in the wiki at work. I'll check with legal and stuff to see if I can paste what I've got here. I'll grep through my svn checkout for 'toObject' and see what I can find out. Cheers, C.J. -- moo. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Mason-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mason-devel