Re: HTML::Mason::FakeApache patch for unparsed_uri, etc.

On Tue, 27 Nov 2007, Daniel Ringwalt wrote:

> This patch to HTML/Mason/FakeApache.pm:
>
> 1. has a working unparsed_uri()
> 2. has uri() and unparsed_uri() return the same value they would under
> Apache::RequestRec
> 3. has a working filename()

This looks pretty good. Is the reason for doing something different under 
taint mode that %ENV is not available, or just that it's tainted? If it's 
the latter, it'd be best to just untaint the value rather than having a 
separate code path.

Also, some tests for this would be really helpful. I think in this case 
it'd be sufficient to patch t/14-cgi.t, rather than the live tests. I can 
update the live tests once you've done that.


-dave

/*===================================================
VegGuide.Org                        www.BookIRead.com
Your guide to all that's veg.       My book blog
===================================================*/

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4