Re: [PATCH] Refactor and split out buffer stack

On Thu, 2008-11-06 at 21:13 -0600, Dave Rolsky wrote:
> On Thu, 6 Nov 2008, John Williams wrote:
> 
> > I, for one, would feel a lot better about it if String::BufferStack were
> > on CPAN.  Adding a dependancy on a non-cpan module is a definite no vote
> > from me, without even considering any other merits.
> 
> I'm sure Alex would release this to CPAN if it were going to be part of 
> Mason, but for now it's just an experiment to see if he can unify the 
> Mason & TD buffers.

Oh, absolutely -- it's on its way there now, in case that was causing
people to hesitate looking at this.  I wasn't going to push it to CPAN
unless people thought the experiment was worth looking at.

To be clear, the experiment is a success, from my point of view.  The
diffstat to Jifty removes a bunch of crufty code, and allows
inter-calling between the templating systems that wasn't possible
before.  For instance, you can $m->scomp a Template::Declare template,
and it Just Works.  Hence why I'm interested in getting this patch
applied.

At this point, I want to know what the chances of inclusion into the
mason core are.  If this patch were possible to do with subclassing the
request object instead, I'd do it and not trouble trunk with the changes
-- the difficulty is that the buffer code is more or less everywhere, so
there's no clean way to subclass the request object without copying more
or less the whole file.
 - Alex	



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/