midcom.services.at (was: [midcom-cvs] CVS update: [...])
Torben Nehmer <[email protected]>
| Newsgroups | gmane.comp.web.midgard.devel |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, - [email protected] wrote on 2006-02-06 13:18: > Log: initial working version of an "AT" service TODO (if you want to stay in core code): - - Adhere to coding styleguide - - Complete documentation for all non-derived members and for derived members with significant functionality Recommend changes for readability / stability for maximum core "code compatibility": - - no while (list = each), use foreach. - - if unserialization for entries fail, check for it (if (! $unserialized)), this should always be done if you @ silence the unserialize call. - - replace $_MIDCOM->dbfactory->new_query_builder($class) with $class::new_query_builder() <-- official OO DBA API - - MidCOM QBs need (as in should never) be @ silenced. - - Report errors to the user when you fail. (There is a print_error in midcom_baseclasses_components_cron_handler, RTFM!) - - The called jobs should always get a reference to the cron handler so that they too can print error messages where required. Live long and Prosper! Torben Nehmer - -- Torben Nehmer, Guenzburg, Bavaria, Germany http://www.nathan-syntronics.de, mailto:[email protected] PGP Public Key: https://www.link-m.de/pgp/t.nehmer.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFD50FTJPh4Kn6d5FYRArjOAJ42TrR6cjvZ/vOeMkS2wYykUP5NJwCfSKtN owQOeV9Z91qP0TSM5x1Q2To= =wFT7 -----END PGP SIGNATURE-----