Re: [midgard-cvs] CVS update: /midgard/src/apis/php4/test/querybuilder/
"Jukka Zitting" <[email protected]> Tue, 21 Feb 2006 09:42:41 +0200
| Newsgroups | gmane.comp.web.midgard.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 20 Feb 2006 21:44:26 -0000, [email protected] <[email protected]> wrote: > /** > * Issue 115. > * mgd_is_guid() fails on strange guids. > */ > function test_migd_is_guid() { > $this->assertGuid("0a3193d4a25611dab74b9d6acce7d1f8d1f8", true); > $this->assertGuid("0a3193d4a25611dab74b9d6acc", false); > $this->assertGuid("0", false); > } Actually mgd_is_guid("0a3193d4a25611dab74b9d6acc") should return true. See the mRFC 0018 definition and the related core test cases: http://midgard.tigris.org/source/browse/midgard/src/core/midgard/test/check_guid.c?view=markup PS. Hmm, there's actually an error in the last assert in test_is_guid in core. We should be enforcing the upper limit length on guids. I'll fix that. BR, Jukka Zitting -- Yukatan - http://yukatan.fi/ - [email protected] Software craftsmanship, JCR consulting, and Java development