Re: MidgardConnection (Was: [midgard-cvs] CVS update: /midgard/src/core/midgard/midgard/)

"Jukka Zitting" <[email protected]> wrote:

> > > Simple mechanism to silence midgard-core:
> > >
> > >     static void null_log_handler(
> > >                     const gchar *domain, GLogLevelFlags log_level,
> > >                     const gchar *message, gpointer data) {
> > >             /* do nothing */
> > >     }
> > >
> > >     g_log_set_handler(
> > >             MIDGARD_LOG_HANDLER, G_LOG_LEVEL_MASK,
> > >             null_log_handler, NULL);
> >
> > That doesn't work :/
> > Or I missed some little detail :/
> 
> Works for me. What's the problem?

All messages are logged unconditionally. 
 
> > > We should replace all explicit "midgard-lib" and "midgard-core" log
> > > domains strings in midgard-core with G_LOG_DOMAIN.
> >
> > What about "repligard" domain?
> 
> It shouldn't be in midgard-core.

It's defined when repligard is compiled , so I need two log handlers for repligard.
 
> AFAIK midgard-core just needs to know the sitegroup and language id
> numbers internally. Why do we need to pass in full objects when we
> could just pass a string (guid or name) that uniquely identifies the
> sitegroup or language in question? (I'd rather not pass the id number
> directly, as we should avoid using them on the API level.)

OK, I prefer guid. I will update header file soon.

Piotras