performance / feature request
lct <[email protected]> 10 Sep 2003 12:31:19 -0000
| Newsgroups | gmane.comp.web.oscommerce.contributions |
|---|---|
| Message-ID | <d7cca25c75d95c6bd47261464561bed1@osCommerce-Forums> |
This message was sent from: Contributions http://forums.oscommerce.com/viewtopic.php?p=227338#227338 ---------------------------------------------------------------- [quote="DiamondSea"][quote="paulm2003"]After installing this (contrib ver 1.2) there are several lines before the doctype declaration: [code]<html> <head> <title>$title</title> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <base href="http://localhost/test.nl/catalog/"> <link rel="stylesheet" type="text/css" href="stylesheet.css"> <!-- start get_javascript(applicationtop2header) //--> <!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN"> <html dir="LTR" lang="en"> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <title>osCommerce</title> <base href="http://localhost/test.nl/catalog/"> <link rel="stylesheet" type="text/css" href="stylesheet.css"> </head> <body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0"> <!-- header //--> <!-- end get_javascript(applicationtop2header) //--> </head> <body>[/code] Am I doing something wrong or is it a little bug? (it does not happen in "normal mode") Thanks for the contrib, it looks very good! Also the comments you added to the PHP code are great, even I can understand some of it now.[/quote] Yes, this is a bug. I'll try to fix it in the next version, as well as mapping the <title> string to the $title variable and adding a variable for "osCsid" parameter for linking on non-cookie sites.[/quote] Greate contribution! First time i took a look at your idea, i thought i must be slower than the "normal" way. But I did a direct comparison of the Page Parse Times of two clean installations and it even seems to be faster with STS !??? Any idea why this could be? "Where light is, there is shadow"... so what will be the disadvantage? More memory-usage? (Couldnt find out yet). the snippet "applicationtop2header" contains not only the JS-Code as it should, so the header-information will be put out a second time. And also the body-tag. I want to have controll of the body-tag via the template, so if you work out a bugfix, take a look on this too. Great work! Am looking for your next update!!! Cord