[TEP-COMMIT] [CVS catalog] allow for empty GET parameters to exist
hpdl-OfajU3CKLf1/[email protected] 29 Mar 2005 22:55:27 -0000
| Newsgroups | gmane.comp.web.oscommerce.cvs |
|---|---|
| Message-ID | <[email protected]> |
<html>
<head>
<style><!--
body {background-color:#ffffff;}
.file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
.pathname {font-family:monospace; float:right;}
.fileheader {margin-bottom:.5em;}
.diff {margin:0;}
.tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
.tasklist ul {margin-top:0;margin-bottom:0;}
tr.alt {background-color:#eeeeee}
#added {background-color:#ddffdd;}
#addedchars {background-color:#99ff99;font-weight:bolder;}
tr.alt #added {background-color:#ccf7cc;}
#removed {background-color:#ffdddd;}
#removedchars {background-color:#ff9999;font-weight:bolder;}
tr.alt #removed {background-color:#f7cccc;}
#info {color:#888888;}
#context {background-color:#eeeeee;}
td {padding-left:.3em;padding-right:.3em;}
tr.head {border-bottom-width:1px;border-bottom-style:solid;}
tr.head td {padding:0;padding-top:.2em;}
.task {background-color:#ffff00;}
.comment {padding:4px;border:1px dashed #000000;background-color:#ffffdd}
.error {color:red;}
hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="4">Commit in <b><tt>catalog/catalog/includes/functions</tt></b><span id="info"> on MAIN</span></td></tr>
<tr><td><tt><a href="#file1">general.php</a></tt></td><td align="right" id="added">+2</td><td align="right" id="removed">-2</td><td nowrap="nowrap" align="center"><a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php?rev=1.244&content-type=text/vnd.viewcvs-markup">1.244</a> <a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php.diff?r1=1.244&r2=1.245">-></a> <a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php?rev=1.245&content-type=text/vnd.viewcvs-markup">1.245</a></td></tr>
</table>
<pre class="comment">
allow for empty GET parameters to exist
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname"><a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog">catalog</a>/<a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog">catalog</a>/<a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes">includes</a>/<a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions">functions</a><br /></span>
<div class="fileheader"><big><b>general.php</b></big> <small id="info"><a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php?rev=1.244&content-type=text/vnd.viewcvs-markup">1.244</a> <a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php.diff?r1=1.244&r2=1.245">-></a> <a href="http://cvs.oscommerce.com/viewcvs.cgi/catalog/catalog/includes/functions/general.php?rev=1.245&content-type=text/vnd.viewcvs-markup">1.245</a></small></div>
<pre class="diff"><small id="info">diff -u -r1.244 -r1.245
--- general.php 2005/02/25 01:56:52 1.244
+++ general.php 2005/03/29 22:55:26 1.245
@@ -146,8 +146,8 @@
</small></pre><pre class="diff" id="context"> if (is_array($_GET) && (sizeof($_GET) > 0)) {
reset($_GET);
while (list($key, $value) = each($_GET)) {
</pre><pre class="diff" id="removed">- if ( (is_string($value) && (strlen($value) > 0)) && ($key != $osC_Session->name) && ($key != 'error') && (!in_array($key, $exclude_array)) && ($key != 'x') && ($key != 'y') ) {
- $get_url .= $key . '=' . rawurlencode($value) . '&';
</pre><pre class="diff" id="added">+ if ( ($key != $osC_Session->name) && ($key != 'error') && (!in_array($key, $exclude_array)) && ($key != 'x') && ($key != 'y') ) {
+ $get_url .= $key . (empty($value) ? '&' : '=' . rawurlencode($value) . '&');
</pre><pre class="diff" id="context"> }
}
}
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" title="commit -> email">CVSspam</a> 0.2.9</small></center>
</body></html>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click