[TEP-COMMIT] CVS: catalog/catalog/includes/boxes reviews.php,1.40,1.41

cvs-OfajU3CKLf1/[email protected] Mon, 16 Feb 2004 08:33:16 +0100
Newsgroups gmane.comp.web.oscommerce.cvs
Message-ID <[email protected]>
Update of /pack/cvsroots/oscommerce/catalog/catalog/includes/boxes
In directory sunsite.dk:/tmp/cvs-serv8827

Modified Files:
	reviews.php 
Log Message:
use the new database class


Index: reviews.php
===================================================================
RCS file: /pack/cvsroots/oscommerce/catalog/catalog/includes/boxes/reviews.php,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -d -r1.40 -r1.41
--- reviews.php	2003/11/17 20:04:53	1.40
+++ reviews.php	2004/02/16 07:26:17	1.41
@@ -5,7 +5,7 @@
   osCommerce, Open Source E-Commerce Solutions
   http://www.oscommerce.com
 
-  Copyright (c) 2003 osCommerce
+  Copyright (c) 2004 osCommerce
 
   Released under the GNU General Public License
 */
@@ -19,24 +19,42 @@
 
   new infoBoxHeading($info_box_contents, false, false, tep_href_link(FILENAME_REVIEWS));
 
-  $random_select = "select r.reviews_id, r.reviews_rating, p.products_id, p.products_image, pd.products_name from " . TABLE_REVIEWS . " r, " . TABLE_REVIEWS_DESCRIPTION . " rd, " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_status = '1' and p.products_id = r.products_id and r.reviews_id = rd.reviews_id and rd.languages_id = '" . (int)$osC_Session->value('languages_id') . "' and p.products_id = pd.products_id and pd.language_id = '" . (int)$osC_Session->value('languages_id') . "'";
-  if (isset($_GET['products_id'])) {
-    $random_select .= " and p.products_id = '" . (int)$_GET['products_id'] . "'";
+  $info_box_contents = array();
+
+  $random_query = 'select r.reviews_id, r.reviews_rating, p.products_id, p.products_image, pd.products_name from :table_reviews r, :table_reviews_description rd, :table_products p, :table_products_description pd where r.products_id = p.products_id and p.products_status = 1 and r.reviews_id = rd.reviews_id and rd.languages_id = :language_id and p.products_id = pd.products_id and pd.language_id = :language_id';
+  if (isset($_GET['products_id']) && is_numeric($_GET['products_id'])) {
+    $random_query .= ' and p.products_id = :products_id';
   }
-  $random_select .= " order by r.reviews_id desc limit " . MAX_RANDOM_SELECT_REVIEWS;
-  $random_product = tep_random_select($random_select);
+  $random_query .= ' order by r.reviews_id desc limit :max_random_select_reviews';
 
-  $info_box_contents = array();
+  $Qreviews = $osC_Database->query($random_query);
+  $Qreviews->bindRaw(':table_reviews', TABLE_REVIEWS);
+  $Qreviews->bindRaw(':table_reviews_description', TABLE_REVIEWS_DESCRIPTION);
+  $Qreviews->bindRaw(':table_products', TABLE_PRODUCTS);
+  $Qreviews->bindRaw(':table_products_description', TABLE_PRODUCTS_DESCRIPTION);
+  $Qreviews->bindInt(':language_id', $osC_Session->value('languages_id'));
+  $Qreviews->bindInt(':language_id', $osC_Session->value('languages_id'));
+  $Qreviews->bindRaw(':max_random_select_reviews', MAX_RANDOM_SELECT_REVIEWS);
 
-  if ($random_product) {
+  if (isset($_GET['products_id']) && is_numeric($_GET['products_id'])) {
+    $Qreviews->bindInt(':products_id', $_GET['products_id']);
+  }
+
+  if ($Qreviews->executeRandomMulti()) {
 // display random review box
-    $review_box_query = tep_db_query("select substring(reviews_text, 1, 60) as reviews_text from " . TABLE_REVIEWS_DESCRIPTION . " where reviews_id = '" . (int)$random_product['reviews_id'] . "' and languages_id = '" . (int)$osC_Session->value('languages_id') . "'");
-    $review_box = tep_db_fetch_array($review_box_query);
+    $Qreview_text = $osC_Database->query('select substring(reviews_text, 1, 60) as reviews_text from :table_reviews_description where reviews_id = :reviews_id and languages_id = :languages_id');
+    $Qreview_text->bindRaw(':table_reviews_description', TABLE_REVIEWS_DESCRIPTION);
+    $Qreview_text->bindInt(':reviews_id', $Qreviews->valueInt('reviews_id'));
+    $Qreview_text->bindInt(':languages_id', $osC_Session->value('languages_id'));
+    $Qreview_text->execute();
 
-    $review_box = tep_break_string(tep_output_string_protected($review_box['reviews_text']), 15, '-<br>');
+    $review_text = tep_break_string($Qreview_text->valueProtected('reviews_text'), 15, '-<br>');
 
-    $info_box_contents[] = array('text' => '<div align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_INFO, 'products_id=' . $random_product['products_id'] . '&reviews_id=' . $random_product['reviews_id']) . '">' . tep_image(DIR_WS_IMAGES . $random_product['products_image'], $random_product['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></div><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_INFO, 'products_id=' . $random_product['products_id'] . '&reviews_id=' . $random_product['reviews_id']) . '">' . $review_box . ' ..</a><br><div align="center">' . tep_image(DIR_WS_IMAGES . 'stars_' . $random_product['reviews_rating'] . '.gif' , sprintf(BOX_REVIEWS_TEXT_OF_5_STARS, $random_product['reviews_rating'])) . '</div>');
-  } elseif (isset($_GET['products_id'])) {
+    $info_box_contents[] = array('text' => '<div align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_INFO, 'products_id=' . $Qreviews->valueInt('products_id') . '&reviews_id=' . $Qreviews->valueInt('reviews_id')) . '">' . tep_image(DIR_WS_IMAGES . $Qreviews->value('products_image'), $Qreviews->value('products_name'), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></div><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_INFO, 'products_id=' . $Qreviews->valueInt('products_id') . '&reviews_id=' . $Qreviews->valueInt('reviews_id')) . '">' . $review_text . ' ..</a><br><div align="center">' . tep_image(DIR_WS_IMAGES . 'stars_' . $Qreviews->valueInt('reviews_rating') . '.gif' , sprintf(BOX_REVIEWS_TEXT_OF_5_STARS, $Qreviews->valueInt('reviews_rating'))) . '</div>');
+
+    $Qreview_text->freeResult();
+    $Qreviews->freeResult();
+  } elseif (isset($_GET['products_id']) && is_numeric($_GET['products_id'])) {
 // display 'write a review' box
     $info_box_contents[] = array('text' => '<table border="0" cellspacing="0" cellpadding="2"><tr><td class="infoBoxContents"><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_WRITE, 'products_id=' . $_GET['products_id']) . '">' . tep_image(DIR_WS_IMAGES . 'box_write_review.gif', IMAGE_BUTTON_WRITE_REVIEW) . '</a></td><td class="infoBoxContents"><a href="' . tep_href_link(FILENAME_PRODUCT_REVIEWS_WRITE, 'products_id=' . $_GET['products_id']) . '">' . BOX_REVIEWS_WRITE_REVIEW .'</a></td></tr></table>');
   } else {



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click