Can't get involved in development
mandreiana <[email protected]>
| Newsgroups | gmane.comp.web.oscommerce.devel |
|---|---|
| Message-ID | <452dadabaefe34f3149129a6c8c68807@osCommerce-Forums> |
This message was sent from: Development
http://forums.oscommerce.com/viewtopic.php?p=157337#157337
----------------------------------------------------------------
I'm using OSC to develop a customer's site. I'm for code re-use/sharing, so I tried to contribute on workboard 50 ( not taken ). I've sent mail to 3 core developers on April 20, which is below, but never got a response. Was it so bad that it didn't deserve a reply??
Hi
I'd like to start working on workboard 50. I'm customizing osCommerce
for a customer now and I run in problems when functions from catalog are
not in admin or behave slightly different ( and vice-versa ).
I would like to keep the functions in classes, if that's ok.
For example, catalog/include/functions/html_output.php has
tep_get_country_list(). That would go in
catalog/include/classes/HTMLOutput.php which looks like
class TEPHTMLOutput {
function get_country_list() ...
}
and be called like TEPHTMLOutput::get_country_list()
The implementation of tep_get_countries() function is different from
catalog to admin. I'd choose the best then grep the code and replace
everywhere with new function called correctly.
I use gnome coding standards, where the functions and variables are like
tep's, but classes are with first letter capital for every word. When
working on tep, I should keep class names like they are now, right? (
tep_html_output, not TEPHTMLOutput )
If this approach is ok, should the tep prefix be still used or replaced
with osc on new classes?
Ultimatelly I'd like includes/classes/ directory to be exactly the same
for both admin and catalog.
Please let me know what do you think and to whom I should send patches.
Thanks,
--
Marius Andreiana
Soluţii informatice bazate pe Linux / Linux-based IT solutions
www.galuna.ro