RE: propose a code change in box structure

burt <[email protected]>
Newsgroups gmane.comp.web.oscommerce.suggestions
Message-ID <341cf98fdf9014a79853722007fa1d1c@osCommerce-Forums>
This message was sent from: Suggestions and Proposals
http://forums.oscommerce.com/viewtopic.php?p=191918#191918
----------------------------------------------------------------

If that was implemented it would be more difficult for a green user to remove out the unwanted infoboxes by // commenting them.

If they did so, they would be left with an unused <tr><td>  </td></tr> which would cause issues with some browsers and so on.

A better proposal ( IMO only !! ) would be to do away with the existing method of creating infoboxes (classes creating nested tables), and use .css

thus:

[code]
<?php
/*
  $Id: information.php,v 1.6 2003/02/10 22:31:00 hpdl Exp $

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2003 osCommerce

  Released under the GNU General Public License
*/
?>
<!-- information //-->
          <tr>
            <td class="infoBoxHeading">
<?php
  echo BOX_HEADING_INFORMATION;
?>
            </td>
          </tr>
          <tr>
            <td class="infoBoxContents">
<?php


  echo '<a href="' . tep_href_link(FILENAME_SHIPPING) . '">' . BOX_INFORMATION_SHIPPING . '</a><br>' .
       '<a href="' . tep_href_link(FILENAME_PRIVACY) . '">' . BOX_INFORMATION_PRIVACY . '</a><br>' .
       '<a href="' . tep_href_link(FILENAME_CONDITIONS) . '">' . BOX_INFORMATION_CONDITIONS . '</a><br>' .
       '<a href="' . tep_href_link(FILENAME_CONTACT_US) . '">' . BOX_INFORMATION_CONTACT . '</a>';

?>
            </td>
          </tr>
<!-- information_eof //-->
[/code]

Stylesheet:
[code]
.infoBoxHeading {
  font-family: Verdana, Arial, sans-serif;
  font-size: 10px;
  font-weight: bold;
  background: #eeeeee;
  color: #000000;
  border-top: 1px;
  border-right: 2px;
  border-left: 1px;
  border-bottom: 0px;
  border-style: solid;
  border-color: #cccccc;
  padding-right: 4px;
  padding-left: 4px;
  padding-top: 2px;
  padding-bottom: 2px;
}

.infoBoxContents {
  background: #eeeeee;
  color: #000000;
  font-family: Verdana, Arial, sans-serif;
  font-size: x-small;
  border-top: 0px;
  border-right: 2px;
  border-left: 1px;
  border-bottom: 2px;
  border-style: solid;
  border-color: #cccccc;
  padding-right: 2px;
  padding-left: 2px;
  padding-top: 3px;
  padding-bottom: 5px;
}
[/code]

Thoughts ?  Doing it this way makes boxes easier to change appearance quickly ( IMO )
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.