RE: Patch files for Contributions?

This message was sent from: Suggestions and Proposals
http://forums.oscommerce.com/viewtopic.php?p=198854#198854
----------------------------------------------------------------

A lot of people don't have patch/diff on their development system, so for many people, a patch file would be just wasted space.  Also, it wouldn't be *a* patch file, it would be multiple patch files.  Very few contributions only modify one file.

The way that (good) contributions do it now is best.  Offer up some context and a line number in a file.  Show changes that need to be made.  Everyone can use this, without switching OSes or buying outside tools.  It provides enough information to handle modified files as well, which can be problematic when applying patch files.  

As to the question of whether it would be better to make guidelines (in fact, look [url=http://forums.oscommerce.com/viewtopic.php?t=30047]here[/url] for what currently exists), sure it would.  However, that's all they would be is guidelines.  It is better to encourage people to share their code, regardless of how they do it.  In other words, it is better to make it possible for people to share their code without having to go through a long redesign process first.  That's the whole purpose of open source, to make people's work generally available, so that others do not have to reinvent the wheel.  

If there was a requirement for patch files, then there would end up being some people who did not know how to make a patch file or did not have the tools.  Rather than go through all the trouble of learning and obtaining, some would simply not bother to share their code.

Cheers,
Matt