Download order bookkeeping

This message was sent from: Suggestions and Proposals
http://forums.oscommerce.com/viewtopic.php?p=212310#212310
----------------------------------------------------------------

I have found it difficult to correct some of my own errors with downloadable products. If, for instance, I use the name of an existing but wrong filename  when entering the name in the attributes section, then any order which uses that item will forever have a bad filename in the order_attributes_download table. If I enter a non-existing filename, then the download is not set up at all. I think both cases are handled wrong.

Here is what I suggest:

1. Do not bookkeep the target filename in order_attributes_download. Instead, use the product_id to get the correct/current download filename from the products_attributes_table. This lets filenames be changed over time by making only one change: the attributes filename. All other processing would immediately adapt to the change.

2. Error check the existence of a download file at the time the name is entered. If it does not exist, create a warning with the option to cancel the operation or proceed anyway.

3. I implemented a "verify download filenames" admin function to help resolve misnaming functions. It is handy, but does not make up for the problems that would be solved by #1 above.

Mike