[20988] Minor fixes for not used code.

Caeies <[email protected]> Wed, 27 Jan 2010 21:02:33 +0000
Newsgroups gmane.comp.web.phpgroupware.cvs
Message-ID <[email protected]>
Revision: 20988
          http://svn.sv.gnu.org/viewvc/?view=rev&root=phpgroupware&revision=20988
Author:   Caeies
Date:     2010-01-27 21:02:33 +0000 (Wed, 27 Jan 2010)
Log Message:
-----------
Minor fixes for not used code.

Modified Paths:
--------------
    modules/phpgwapi/trunk/inc/class.acl.inc.php
    modules/phpgwapi/trunk/inc/class.categories.inc.php
    modules/phpgwapi/trunk/inc/class.http_svn_client.inc.php

Modified: modules/phpgwapi/trunk/inc/class.acl.inc.php
===================================================================
--- modules/phpgwapi/trunk/inc/class.acl.inc.php	2010-01-27 18:05:18 UTC (rev 20987)
+++ modules/phpgwapi/trunk/inc/class.acl.inc.php	2010-01-27 21:02:33 UTC (rev 20988)
@@ -477,8 +477,8 @@
 				$appname = $GLOBALS['phpgw_info']['flags']['currentapp'];
 			}
 
-
-			$count = (isset($this->_data[$this->_account_id])?count($this->_data[$this->_account_id]):0);
+			//XXX Caeies :not used any more ?
+			//$count = (isset($this->_data[$this->_account_id])?count($this->_data[$this->_account_id]):0);
 			$rights = 0;
 
 			if(isset($this->_data[$this->_account_id]) && is_array($this->_data[$this->_account_id]))
@@ -1152,7 +1152,7 @@
 				$groups = $this->get_location_list_for_id('phpgw_group', 1, $this->_account_id);
 				if ( is_array($groups) && count($groups) )
 				{
-					foreach ( $groups as $key => $value )
+					foreach ( $groups as $value )
 					{
 						if ( !$value )
 						{

Modified: modules/phpgwapi/trunk/inc/class.categories.inc.php
===================================================================
--- modules/phpgwapi/trunk/inc/class.categories.inc.php	2010-01-27 18:05:18 UTC (rev 20987)
+++ modules/phpgwapi/trunk/inc/class.categories.inc.php	2010-01-27 21:02:33 UTC (rev 20988)
@@ -564,7 +564,7 @@
 		{
 			if(is_array($data))
 			{
-				$format			= isset($data['format']) ? $data['format'] : 'filter';
+				$format			= isset($data['format']) ? $data['format'] : 'filter'; //XXX Caeies : not used anymore ?
 				$type			= isset($data['type']) ? $data['type'] : 'all';
 				$selected		= isset($data['selected']) ? $data['selected'] : '';
 				$self			= isset($data['self']) ? $data['self'] : '';

Modified: modules/phpgwapi/trunk/inc/class.http_svn_client.inc.php
===================================================================
--- modules/phpgwapi/trunk/inc/class.http_svn_client.inc.php	2010-01-27 18:05:18 UTC (rev 20987)
+++ modules/phpgwapi/trunk/inc/class.http_svn_client.inc.php	2010-01-27 21:02:33 UTC (rev 20988)
@@ -187,7 +187,7 @@
 		*/
 		function getVersions($uri,$startvers,$endvers)
 		{
-			$ret=$this->report($uri,$startvers,$endvers);
+			$ret=$this->report($uri,$startvers,$endvers); //XXX Caeies : not used ?
 			$xml_result=$this->http_client->getBody();			
 			if ( !is_object($this->svn_processor))
 			{
@@ -258,7 +258,7 @@
 			$numofentry=0;
 			$rjournal=array();
 			
-			while(list ($num, $entry_journal) = each ($journal))
+			while(list (, $entry_journal) = each ($journal))
 			{
 				++$numofentry;
 				$rjournal[]=$entry_journal;