RE: New logo trial
Sigurd Nes <[email protected]>
| Newsgroups | gmane.comp.web.phpgroupware.devel |
|---|---|
| Message-ID | <[email protected]> |
> From: Maât [[email protected]] > Sent: 2008-05-03 19:22:09 CEST > To: [email protected], [email protected] > Subject: [phpGroupWare-developers] New logo trial > > Hi all, > > I've started to work on phpGroupWare developer's guide > > here is the first draft : > > http://home.vilarem.net/phpgroupware/phpgroupware_developer_guide_draft0_en_US.pdf > > (i've also slightly changed the logo to colorize it a little bit but > that's just a trial) > > please tell me what you think... > A great start (- and the logo is very nice) Some first remark on the developer guide: *1) 3.2.2.4 class.menu.inc.php file: I think there is a preferences section - as: if ( isset($GLOBALS['phpgw_info']['user']['apps']['preferences']) ) { $menus['preferences'] = array ( *2) the baseline.inc.php in setup: is it needed? *3) 6 Database layer in depth: Might have something on transactions here? example: $this->db->transaction_begin(); foreach ($array as $dataset) { $this->db->query("INSERT INTO... } if(!some condition) { $this->db->transaction_abort(); $receipt['error'][] = array('msg'=> lang('an error message')); } else { $this->db->transaction_commit(); $receipt['message'][] = array('msg'=> lang('success')); } *4) translations for menu items (within applications) in common? (all menus for all apps are parsed at login) *5) 10.1 Standard requirements - at least php 5.2 *6 11.2 Hooking into Administration page - handled by the new menu 11.3 Hooking into Preferences page - handled by the new menu *7) Some words on ACL2, custom fields and custom functions? Regards Sigurd _______________________________________________ phpGroupWare-developers mailing list [email protected] http://lists.gnu.org/mailman/listinfo/phpgroupware-developers