Re: sql strengthening in class.accounts_.inc.php

Maât <[email protected]> Tue, 03 Jun 2008 17:03:56 +0200
Newsgroups gmane.comp.web.phpgroupware.devel
Message-ID <[email protected]>
Next patch... a tiny one for greater security.

regards,
Maât

_______________________________________________
phpGroupWare-developers mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/phpgroupware-developers
class.accounts_.inc.php.patch (text/plain, 678 B)
Index: phpgwapi/inc/accounts/class.accounts_.inc.php
===================================================================
--- phpgwapi/inc/accounts/class.accounts_.inc.php	(revision 18589)
+++ phpgwapi/inc/accounts/class.accounts_.inc.php	(working copy)
@@ -434,7 +434,7 @@
 		function get_members()
 		{
 			$members = array();
-			$sql = "SELECT acl_account FROM phpgw_acl WHERE acl_appname = 'phpgw_group' and acl_location =" . (int) $this->account_id;
+			$sql = "SELECT acl_account FROM phpgw_acl WHERE acl_appname = 'phpgw_group' and acl_location ='" . (int) $this->account_id . "'";
 			$this->db->query($sql,__LINE__,__FILE__);
 			while ($this->db->next_record())
 			{