Re: [patch #6572] A test on using PDO in db-class

Sigurd Nes <[email protected]> Sat, 19 Jul 2008 17:25:26 +0200
Newsgroups gmane.comp.web.phpgroupware.devel
Message-ID <[email protected]>
Sigurd Nes wrote:
> Sigurd Nes wrote:
>>> From: Maât [[email protected]]
>>> Sent: 2008-07-18 08:17:31 CEST
>>> To: [email protected]
>>> Subject: Re: [phpGroupWare-developers] [patch #6572] A test on using PDO in	db-class
>>>
>>> Sigurd Nes a écrit :
>>>> Hi all,
>>>>
>>>> I did a test on using PDO for db-connection.
>>>> The code is based on the current db-class from trunk and the tutorial found at:
>>>> http://www.phpro.org/tutorials/Introduction-to-PHP-PDO.html
>>>>
>>>> Seems like it is about 5 % faster on reading and 20 % faster on writing compared
>>>> to adodb with eaccelerator (had hoped for more).
>>>>
>>>> The class is not 100% complete - but most of it works.
>>>>
>>>> http://savannah.gnu.org/patch/download.php?file_id=16131
>>>>
>>>> What do you think ?
>>>>   
>>> nice try !
>>>
>>> thanks Sigurd :)
>>>
>> I think we also could have a look at Prepared Queries - maybe something as the second example on this page:
>> http://www.devshed.com/c/a/PHP/Working-with-Prepared-Queries-with-PDO-Objects-in-PHP-5/2/
>>
> The class is updated to handle prepared prepared statements for insert and
> select (function insert() and function select())
> 
> Might be good for preventing sql-injections.
> 
> The test include test on FETCH_ASSOC and FETCH_BOTH - seems to make no
> difference in performance (speed).
> 
I have finished the porting of the db-class from adodb to pdo (except for some
meta functions - which still calls adodb).

It is faster - and it support prepared statements for insert and select.

https://savannah.gnu.org/patch/download.php?file_id=16157

I have also done a test conversion to the rest of the system - and there is
minor changes to functions.inc.php and class.applications.inc.php to make it work.

What do you think?

Regards

Sigurd