Re: Re: Where is Files?

Dave Hall <[email protected]> Fri, 02 Nov 2007 23:26:53 +1100
Newsgroups gmane.comp.web.phpgroupware.general
Organization Dave Hall Consulting
Message-ID <[email protected]>
On Thu, 2007-11-01 at 21:03 -0700, Gennady wrote:
> 
> It seems that there's a bug in the code. I have managed to find and fix it. 
> 
> Here is the fix:
> In file phpgwapi/inc/class.vfs_sql.inc.php around line 125 find the following line:
>                        $docroots = array(PHPGW_SERVER_ROOT,$GLOBALS['HTTP_SERVER_VARS']['DOCUMENT_ROOT']);
> 
> and change it to:
>                        $docroots = array(PHPGW_SERVER_ROOT,$_SERVER['DOCUMENT_ROOT']);
> 
> 
> This has finally let me use the trouble ticket system and shows a form when I do new ticket. 
> 
> While I am at it here is another small change that removed a warning during installation (diff -u format):
> 
> --- phpgwapi/inc/class.setup.inc.php    5 Oct 2005 12:37:20 -0000       1.15.2.19
> +++ phpgwapi/inc/class.setup.inc.php    2 Nov 2007 03:37:10 -0000
> @@ -772,7 +772,7 @@
> 
>                 function get_hooks_table_name()
>                 {
> -                       if($this->alessthanb($GLOBALS['setup_info']['phpgwapi']['currentver'],'0.9.8pre5') && ($GLOBALS['setup_info']['phpgwapi']['currentver'] != ''))
> +                       if($this->alessthanb($GLOBALS['setup_info']['phpgwapi']['version'],'0.9.8pre5') && ($GLOBALS['setup_info']['phpgwapi']['version'] != ''))
>                         {
>                                 /* No phpgw_hooks table yet. */
>                                 return False;
> 
> 
> Basically changed the line from currentver to version.

Thanks for the fixes.  I will test these out and if it works as it
should I would commit them.  In future please submit patches as per
http://support.phpgroupware.org/patches it makes it easier for
everyone :)

My inbox never functions very well as a todo list :(

Cheers

Dave