[patch #5438] addressbook produce a endless loop

Andy Tschiersch <[email protected]>
Newsgroups gmane.comp.web.phpgroupware.tracker
Message-ID <[email protected]>
URL:
  <http://savannah.gnu.org/patch/?5438>

                 Summary: addressbook produce a endless loop 
                 Project: phpGroupWare
            Submitted by: tschan
            Submitted on: Montag 02.10.2006 um 22:29
                Category: addressbook
                Priority: 5 - Normal
              Item Group: 0.9.16 (stable)
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open

    _______________________________________________________

Details:

Target Branch: 0.9.16, HEAD
Purpose: Under PHP5 the addressbook loads endless or until max_execution_time
is reached.

Bug is locatet on line 464:
while ($column = @each(($all_cols_to_display)))

The array cursor was not increased.
Have found 2 working solutions.

Solution 1 (used in this patch):
while ($column = @each($all_cols_to_display))

Solution 2: (without @)
while ($column = each(($all_cols_to_display)))




Format: diff
Affected file: /addressbook/inc/class.uiaddressbook.inc.php





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Montag 02.10.2006 um 22:29  Name: addressbook.diff  Size: 588B   By:
tschan
run 'patch -p1 &lt; addressbook.diff' under phpgroupware dir
<http://savannah.gnu.org/patch/download.php?file_id=10888>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5438>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.