[ phpopencounter-Bugs-720193 ] get_parameter_filters not working as expected

"SourceForge.net" <[email protected]> Sat, 12 Apr 2003 06:05:46 -0700
Newsgroups gmane.comp.web.phpopentracker.devel
Message-ID <[email protected]>
Bugs item #720193, was opened at 2003-04-12 13:05
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101716&aid=720193&group_id=1716

Category: Logging Module
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Alan McFarlane (amcfarlane)
Assigned to: Nobody/Anonymous (nobody)
Summary: get_parameter_filters not working as expected

Initial Comment:
It appears that the configuration 
variable 'get_parameter_variables' whilst being used 
does not produce the (in my mind) correct results.

Your code for stripping these variables currently expects 
the variables to be formatted thus:

$container['document_url'] = preg_replace(
    '#\?' .
    $filter .
    "=.{32}$|&" .
    $filter .
    "=.{32}$|" .
    $filter .
    '=.{32}&#msiU',
    '',
    $container['document_url']
);

Now, I understand, this will only strip get parameters 
that have exactly 32 characters (of any type) - such as 
session ids or a md5 number.

Would it not be more sensible to just name the relevant 
parameters to be stripped and not to rely on a fixed 
length value; For example:

$container['document_url'] = preg_replace(
    '#\?' .
    $filter .
    "=.*$|&" .
    $filter .
    "=.*$|" .
    $filter .
    '=.*&#msiU',
    '',
    $container['document_url']
);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101716&aid=720193&group_id=1716


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com