[ phpopencounter-Bugs-720193 ] get_parameter_filters not working as expected

Bugs item #720193, was opened at 2003-04-12 15:05
Message generated for change (Comment added) made by bergmann
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101716&aid=720193&group_id=1716

Category: Logging Module
Group: None
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Alan McFarlane (amcfarlane)
Assigned to: Nobody/Anonymous (nobody)
Summary: get_parameter_filters not working as expected

Initial Comment:
It appears that the configuration 
variable 'get_parameter_variables' whilst being used 
does not produce the (in my mind) correct results.

Your code for stripping these variables currently expects 
the variables to be formatted thus:

$container['document_url'] = preg_replace(
    '#\?' .
    $filter .
    "=.{32}$|&" .
    $filter .
    "=.{32}$|" .
    $filter .
    '=.{32}&#msiU',
    '',
    $container['document_url']
);

Now, I understand, this will only strip get parameters 
that have exactly 32 characters (of any type) - such as 
session ids or a md5 number.

Would it not be more sensible to just name the relevant 
parameters to be stripped and not to rely on a fixed 
length value; For example:

$container['document_url'] = preg_replace(
    '#\?' .
    $filter .
    "=.*$|&" .
    $filter .
    "=.*$|" .
    $filter .
    '=.*&#msiU',
    '',
    $container['document_url']
);


----------------------------------------------------------------------

>Comment By: Sebastian Bergmann (bergmann)
Date: 2003-05-26 12:23

Message:
Logged In: YES 
user_id=7993

Applied your patch in CVS.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101716&aid=720193&group_id=1716


-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge