Re: I port polipo to VS2008 under Win32

> now i change ms_port into 10 patches ,all in one file. I just use the
> command:
>    git format-patch master --stdout >../ms_port.patch
> should i part to 10 different patch files? i don't know how to do it.
> as i beginner for using git,i still not quit familiar with it.

That's fine.

(The usual convention is to use "git send-email", which creates a thread
on a mailing list.)

>  i implement a change_to_dir() for Windows ,but now only work for VC,i will
> do it later to make it work for MINGW.

I don't think that the on-disk cache works under MINGW in the first
place.

Here's my review of this latest batch:

There's no author name in the patches, see

  http://www.kernel.org/pub/software/scm/git/docs/user-manual.html#telling-git-your-name

The files dirent.{c,h} should be renamed to something like
"win-dirent", so there's no risk of confusion with the system versions.

The dirent emulation code carries no copyright notice, and doesn't use
the same indentation style as the rest of Polipo.

The mktime_gmt function uses eight-character tabs.  (Chris: I haven't
tested it under SYSV, but it should work there, and it's cleaner than
the putenv(TZ) code we're currently using.)

I don't think the project file should be included in Polipo.

Other than that, it looks good to me.

                                        Juliusz

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com