Re: two patches: avoid NULL-dereference

Juliusz Chroboczek <[email protected]>
Newsgroups gmane.comp.web.polipo.user
Message-ID <[email protected]>
>> That's incorrect.

> "Incorrect" ?
[...]
> I guess you mean "undesirable" or "contrary to policy".

I s'pose I do.

> Here's an alternative patch (untested):

> +        if(request == NULL)
> +            return;

No, that's still "undesirable", since specialRequestHandler will never
be invoked, and hence will never get a chance to either notify the
client or release the object (notice the retainObject above).

--Juliusz

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.