Re: [PATCH] Fix variable setting in the local interface

Gabriel Kerneis <[email protected]>
Newsgroups gmane.comp.web.polipo.user
Message-ID <[email protected]>
David,

Thanks for the feedback.

On Mon, Nov 12, 2012 at 05:23:09PM +0000, David Röthlisberger wrote:
> On 12 Nov 2012, at 15:47, Gabriel Kerneis wrote:
> > This patch fixes two bugs in httpSpecialClientSideHandler (local.c).
> + curl -F "clientTimeout=3m" http://localhost:8123/polipo/config
>   now hangs waiting for a response, every time. Before this patch it used
>   to receive the "503 Post aborted", every time.
>   I don't know if this is caused by your change, or whether the bug you
>   fixed was previously masking this problem.
> 
> With curl, I *once* got the following error from polipo when I killed the
> curl process:
> 
>     Incomplete client request.
>     Assertion failed: (!object->chunks[i].locked), function destroyObject, file object.c, line 661.
>     Abort trap: 6           ./polipo

I can reproduce this reliably.  On second thought, I should probably set/clear
the flag OBJECT_INPROGRESS instead of testing OBJECT_INITIAL, my patch doesn't
make much sense.  But this does not solve the issue anyway, I'll continue
investigating.

-- 
Gabriel

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.