Re: Polipo request times out; and polipo crashes

On 15 Nov 2012, at 11:39, Fabian Keil wrote:
> The attached patches 1 to 3 seem to prevent the crashes
> for me, patch 4 is an unrelated bonus.

I ran my original test[1] against Fabian's patches. Just to be clear,
the patches aim to address various segfaults (including issue 2 from my
email dated 23 February 2012), but not the incomplete request (issue 1).

[1] http_proxy=http://localhost:8123/ curl --silent http://localhost:9393/ -F f=hello

With only patch #1 applied, that first segfault was indeed avoided, but
then polipo reached the segfault addressed by patch #3.

With patches #1 and #3 applied, polipo proceeded further but then
segfaulted (intermittently) at:

    #0  httpServerDoSide (connection=0x107c04060) at server.c:984
    984	    HTTPConnectionPtr client = requestor->connection;
    #1  0x0000000107b6e51a in httpClientDelayedDoSideHandler (event=0x107c04060) at server.c:1064
    #2  0x0000000107b59bb6 in runTimeEventQueue () at event.c:492
    #3  0x0000000107b5a37e in eventLoop () at event.c:654
    #4  0x0000000107b64d5a in main (argc=2, argv=0x7fff67757830) at main.c:165

The same segfault happened with patches 1, 2 & 3 applied, and also with
all 4 patches applied. This is on OS X x86_64.

I have no comment on the code changes themselves -- I don't know the
code well, and haven't spent any time studying the functions you've
changed. (Sorry!)

> I've been using curl's test framework for a couple of years now
> to test Privoxy and intend to upstream my modifications in the
> near future after some more polishing.
> 
> Once that's done, using the tests with Polipo should be more
> convenient as well.

This is great news! Do keep us informed.

--Dave.


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov