Re: Release date for Privoxy 3.0.19 stable

Lee <[email protected]> wrote:

> On 12/28/11, Fabian Keil <[email protected]> wrote:
> > Lee <[email protected]> wrote:
> >
> >> On 12/27/11, Fabian Keil <[email protected]> wrote:
> >> > Lee <[email protected]> wrote:
> >
> >> >> I finally got around to checking email again..  Windows build is up on
> >> >> SF and, after a bit of poking around, privoxy-setup 3.0.19 is the
> >> >> default windows download :)
> >> >
> >> > Great. I assume you built it with IPv6 support?
> >>
> >> Yes.  I did the build on a Vista machine using winsetup/GNUmakefile so
> >> the configure options were
> >>   ./configure --enable-mingw32 --disable-pthread
> >> --disable-dynamic-pcre --enable-zlib
> >
> > It's unfortunate that --disable-dynamic-pcre seems to be
> > necessary on Windows, but other than that these look like
> > reasonable settings for most users.
> 
> All that's required is "./configure --enable-mingw32".

My main concern (which I didn't clearly articulate above) is that
the outdated internal pcre version is used. At least a few years
ago linking to a more recent version wasn't an option on Windows. 

> >> > Do you think it would be feasible to provide both flavours?
> >>
> >> There's a slight problem.  Doing a build on Vista after a
> >>   ./configure --enable-mingw32 --disable-ipv6-support
> >> dies with
> >> gcc -c -pipe -O2 -DWINVER=0x501   -mwindows -mno-cygwin -Wall -Ipcre
> >> jbsockets.c -o jbsockets.o
> >> jbsockets.c: In function `get_host_information':
> >> jbsockets.c:979: error: `NI_MAXSERV' undeclared (first use in this
> >> function)
> >> jbsockets.c:979: error: (Each undeclared identifier is reported only once
> >> jbsockets.c:979: error: for each function it appears in.)
> >> make[1]: *** [jbsockets.o] Error 1
> 
> For whatever it's worth
>   ./configure --enable-mingw32 --disable-ipv6-support
>   make
> on WinXP also dies

I don't think we can blame it (this time).
 
> > Interesting. We probably shouldn't use that define when
> > --disable-ipv6-support has been used anyway.
> 
> Probably not.. dunno if it's worth the effort to redo the code when we
> could just do a
> #ifndef NI_MAXSERV

Using our own define, naming it to something like
MAX_PORTSTRING_LENGTH and setting it to NI_MAXSERV
if it's available, and 32 otherwise, would also make
the code easier to read (I think), so I'd consider it
worth it.
 
> > Does moving the "#include <netdb.h>" above the first
> > "#ifdef _WIN32" in jbsockets.c work?
> 
> I've seen a few warnings about not mixing windows headers and cygwin
> headers.  It'd probably be safer to do
> > If it doesn't, simply defining NI_MAXSERV should do:
> >
> > #ifndef NI_MAXSERV
> > #define	NI_MAXSERV	32
> > #endif
> >
> > 32 is the value used on FreeBSD and more than big enough
> > to contain any port number as string.
> 
> 32 is also the value in the windows header :)
> w32api/ws2tcpip.h:95:#define NI_MAXSERV 32

I agree that the #ifndef workaround is less likely
to cause problems and thus probably the best option.

Fabian

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox

_______________________________________________
Ijbswa-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ijbswa-developers

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iEYEARECAAYFAk77k5MACgkQSMVSH78upWPYpgCghPkdK6qNHvwpIk3D42nFUR9w
cRoAn3ZXLZibqTesfC82VfDYVTqz0aY5
=2ybL
-----END PGP SIGNATURE-----