Re: Adding a "--dry-run" commandline option

Ramkumar Chinchani <[email protected]> wrote:

> On Wed, 7 Nov 2012 13:41:04 +0100
> Fabian Keil <[email protected]> wrote:
> 
> > > One of the components of the freedombox project is the privoxy with
> > > updated frequently from Adblock-plus and https_everywhere
> > > projects. 
> > 
> > But the converted files will be (eventually) coming from a
> > trusted server operated by the FreedomBox project and are
> > properly reviewed, right?
> 
> I expect that to be a long-term goal. However for now, converter
> scripts sit in between various upstream files and privoxy, and the
> attached patch would certainly help in vetting the output when
> frequently playing catch up. That said, I agree that a more rigorous
> vetting process is needed.

Great.
 
> > > Please consider the following patch (tested on Linux only)
> > 
> > Thanks for the patch.
> > 
> > I agree that it would be an improvement. I don't like "--dry-run"
> > as it (to me) implies something else, but wouldn't mind committing
> > the attached modified version despite the limitations noted in the
> > commit message.
> 
> Thanks.

Committed.

Fabian

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov

_______________________________________________
Ijbswa-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ijbswa-developers

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCc4Z4ACgkQSMVSH78upWM+GwCfSo8IezSVLyUUZ5VQ3maOULFs
SlsAn21zgg9V/bP8xFgbzjjLUpN1CBrw
=+6Ep
-----END PGP SIGNATURE-----