Re: check for regression-tests.action?

On 14-11-17 2:31 PM, Fabian Keil wrote:
> Ian Silvester <[email protected]> wrote:
>
>> On 14-11-17 1:35 PM, Fabian Keil wrote:
>>> Lee <[email protected]> wrote:
>>>
>>>> Could privoxy-regression-test.pl be changed so that it gives a warning
>>>> if there is no regression-tests.action configured?
>>> It's a valid configuration, so I'm not sure it would be a good
>>> default, but I guess having a "packaging" mode that enables this
>>> and other warnings wouldn't hurt.
>>>
>>>> I remembered to copy regression-tests.action to C:\Program Files
>>>> (x86)\Privoxy but forgot to add it in config.txt :(
>>>> So I thought everything passed & that turns out not to be the case:
>>>>
>>>> /source/privoxy-3.0.22-stable/current/tools
>>>> $ ./privoxy-regression-test.pl --max-level 200 --privoxy-address 127.0.0.1:8118
>>>> 2014-11-17 10:45:05: Asking Privoxy for the number of action files available ...
>>>> 2014-11-17 10:45:05: Gathering regression tests from 4 action file(s)
>>>> delivered by Privoxy 3.0.22.
>>>> 2014-11-17 10:45:06: Executing regression tests ...
>>>> 2014-11-17 10:45:45: Ooops. Got: 'REMOVAL' while expecting: 'NO CHANGE'
>>>> 2014-11-17 10:45:45: Failure for test 514. Header 'Keep-Alive: 20' and
>>>> tag 'Parse Keep-Alive header'
>>>> 2014-11-17 10:45:45: Ooops. Got: 'REMOVAL' while expecting: 'NO CHANGE'
>>>> 2014-11-17 10:45:45: Failure for test 515. Header 'Keep-Alive:
>>>> timeout=20, max=3' and tag 'Parse Keep-Alive header'
>>>> 2014-11-17 10:45:45: Ooops. Got: 'REMOVAL' while expecting: 'NO CHANGE'
>>>> 2014-11-17 10:45:45: Failure for test 516. Header 'Keep-Alive:
>>>> blah=fasel, timeout=20, max=3' and tag 'Parse Keep-Alive header'
>>>> 2014-11-17 10:46:02: Executed 687 regression tests. Skipped 27. 684
>>>> successes, 3 failures.
>>> I believe the problem here is that the tests are executed even though
>>> they aren't supposed to pass. They are executed if keep-alive-timeout is
>>> set to any digit but actually require a keep-alive-timeout of 20 or more
>>> to pass.
>> Thanks Fabian - I looked into keep-alive-timeout (the only failure I
>> had) and in the default 3.0.22 config file it claims that we have a
>> default of 'None' where in fact by default it is set to 5 (for reasons
>> explained in this setting's Notes). Two things then:
>>
>> - we can disregard this regression test for a default installation since
>> it will always fail
> Yes.
>
>> - there is a (minor) error in the config file - it should quote the
>> default value of 5 rather than None, correct?
> No.
>
> While 5 is the value set in the config file, "default value" refers
> to the internal default value Privoxy uses if the directive isn't used
> at all. Often the values specified in the config file match the default
> values, but sometimes they don't.
>
> Maybe the "Default value" and "Effect if unset" sections should be
> renamed to clarify this.
Thanks for the clarification Fabian.

I think that "Effect if unset" is clear (and the config preamble helps), 
but "Default" is not clear. I think an explanation should be added to 
section II at the top of the file to explain the difference between the 
"Default" comment and the default value specified in a vanilla config file.

Ian

>
> Fabian
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
>
>
> _______________________________________________
> Ijbswa-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ijbswa-developers

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

_______________________________________________
Ijbswa-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ijbswa-developers