Re: weblogsping.py error handling patch
will guaraldi <[email protected]>
| Newsgroups | gmane.comp.web.pyblosxom.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 29 Aug 2006, Blake Winton wrote: > > So raising an exception is approximately 1.4 times slower than doing an > addition... I still don't think that's too slow. I disagree. I think a factor of 1.4 is a big deal. > I'd buy your math, but I'ld love to see some actual numbers. I've got > 280 posts, and 16 plugins, for a total of 4480. Does anyone have any > better numbers? Will, would you like to re-run my tests with some more > realistic values? (Say 20 plugins, and 10,000 entries? 25 plugins and > 5,000 entries?) > > I guess my point is that even at 3 seconds, you're talking about 20 > plugins and 500,000 entries. So if it scales linearly you're looking at > a 0.06 second slowdown for 20 plugins and 10,000 entries; 0.75 seconds > for 25 plugins and 10,000 entries; and so on... > > Hmm, maybe what I'm trying to say is: We should run some benchmarks > before and after the change, and see if the actual implementation is too > slow. I think we both agree that it does cause a performance degradation and that's all I was saying. You say 1.4 times isn't a big deal, but I think it is a big deal. So there we differ in opinion. Profiling PyBlosxom is a good idea and I think it's one of the TODO items if someone is interested in doing some optimization work. Regardless, that's not my main issue with the change. My main issue with the change is that I'd rather have things fail immediately when something unexpected happens rather than at some unspecified point down the road because the system was in a funky state. /will ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642