Re: [PATCH] Trackback+akismetcomments
Ryan Barrett <pyblosxom-6sb6M7qyT/[email protected]>
| Newsgroups | gmane.comp.web.pyblosxom.devel |
|---|---|
| Message-ID | <[email protected]> |
hi mike! you might have noticed that i checked in part of this patch in revision 1179, along with a unit test for akismetcomments. http://pyblosxom.svn.sourceforge.net/viewvc/pyblosxom?view=rev&revision=1179 i didn't include the parts that you said you were redoing. if/when you check those parts in, would you mind adding tests for them? thanks in advance... On Thu, 6 Dec 2007, Michael Guntsche wrote: > On Thu, 6 Dec 2007 00:27:43 -0800 (PST), Ryan Barrett <pyblosxom-6sb6M7qyT/[email protected]> > wrote: >> honestly, i don't know. i'd never really looked at akismetcomments.py >> before >> now. i'm ok with committing the patch as is, but if you think you can >> clean it >> up, i'll be happy to take a look at whatever you come up with. (assuming >> you've tested it and both plugins work, of course.) > > I cleaned up the Ajax related stuff over the last few days. Instead of > sending back plain HTML I send back a JSON object. This way I can put in > additional information (is it SPAM or HAM right now) I then can use in the > javascript. I am planning to make several commits (hopefully this weekend > if time permits). > The first should clean up trackback+akismet support but does not change too > much code. > I'll post the second (JSON) to the mailinglist for review as soon as I have > given it a little bit more testing. Right now I am using simplejson so if > this goes in, ajax comments would depend on it which is another point to > talk about. > > /Mike > > > ------------------------------------------------------------------------- > SF.Net email is sponsored by: The Future of Linux Business White Paper > from Novell. From the desktop to the data center, Linux is going > mainstream. Let it simplify your IT future. > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 > _______________________________________________ > Pyblosxom-devel mailing list > Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel > -Ryan -- http://snarfed.org/ ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/