getting openid comments to work
Peter Meerwald <[email protected]>
| Newsgroups | gmane.comp.web.pyblosxom.devel |
|---|---|
| Message-ID | <[email protected]> |
Hello, I set up pyblosxom with the openid_server and openid_comment plugin and ran into a couple of issues: 1. if an OpenID request is handled, cmtExpr() in comments.py breaks because entry['absolute_path'] and entry['fn'] both return None and the code subsequently fails when using the None values; so I added a check to just return in case None is returned 2. the locking code in session.py is broken, ie. _lock() and _unlock(); if the file to lock does not (yet) exist, an exception is thrown; I suggest to use exception handlers within these methods 3. comments_openid.py only passed one parameter to consumer.complete() in complete_openid_auth(), however, newer python-openid libraries require a second parameter; this can be easily fixed with the following line # Ask the OpenID library to check the server's response response = consumer.complete(query, return_to) I'd appreciate if above issues could be fixed in the repository; please contact me if more detail is required thanks, regards, p. -- Peter Meerwald Kaigasse 3 / 8 A-5020 Salzburg / AUSTRIA +43-664-2444418 (mobile) ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone