Re: BUG in lucene.py plugin

Sorry Ryan,

as I've discussed it with Mario yet, there wasn't one parenthesis too
much at the expression's beginning, there was one missing at the
expression's end instead. The patch as you have applied it won't work as
well because of the line break. If you put a line break between an
expression, you need to put parentheses around it.

I've relied on Mario and Mario has probably relied on me to report this...

I've attached a new patch against the current version in the trunk.


Cheers,

Klaus



Ryan Barrett wrote:
> thanks for the patch! i've applied it. sorry for the month and a half
> delay. :P
> 
> On Wed, 21 May 2008, Mario Fern�ndez wrote:
> 
>> Hi,
>>
>> I filed a bug report about this, but there is no answer there, and the
>> fix is really trivial, so I thought I might as well send the diff here:
>>
>> --- old_lucene.py    2008-05-21 22:09:28.000000000 -0700
>> +++ lucene.py    2008-05-21 22:12:40.000000000 -0700
>> @@ -121,15 +121,17 @@
>>      """
>>      urllib.quote(term)
>>      JAVA_HOME = config['JAVA_HOME']
>> -    classpath = (':'.join(glob.glob(config['lucene_home'] + '/*.jar') +
>> +    classpath = ':'.join(glob.glob(config['lucene_home'] + '/*.jar') +
>>                   [config['lucene_bin']])
>>      index = config['lucene_index']
>>      cmd = (JAVA_HOME + ' -cp ' + classpath + ' LuceneSearch ' +
>> index + ' ' +
>>             term)
>>
>> Cheers,
>> Mario
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Pyblosxom-devel mailing list
>> Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel
>>
> 
>  -Ryan
> 
> -- 
> http://snarfed.org/
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Pyblosxom-devel mailing list
> Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08

_______________________________________________
Pyblosxom-devel mailing list
Pyblosxom-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/pyblosxom-devel

--- old_lucene.py	2008-07-04 12:54:30.000000000 +0200
+++ lucene.py	2008-07-04 12:55:17.000000000 +0200
@@ -121,8 +121,8 @@
     """
     urllib.quote(term)
     JAVA_HOME = config['JAVA_HOME']
-    classpath = ':'.join(glob.glob(config['lucene_home'] + '/*.jar') +
-                 [config['lucene_bin']])
+    classpath = (':'.join(glob.glob(config['lucene_home'] + '/*.jar') +
+                 [config['lucene_bin']]))
     index = config['lucene_index']
     cmd = (JAVA_HOME + ' -cp ' + classpath + ' LuceneSearch ' + index + ' ' +
            term)