Re: Trackback plugin broke?

On Sun, 27 Mar 2005 18:02:58 -0800, Ted Leung wrote:

> Hi Eric,
> 
> I think I found the problem.  Could you put the out.write back into 
> pyblosxom.py and try this version of trackback.py?  The problem is that 
> trackback wasn't writing to the new response object.  Let me know if 
> this solves your problems.
> 

Ted,
	I still get a stray "Status: " string on stdout with this version.
	Commenting out the line:

	out.write("Status: %s\n" % self.status)

	solves the issue and brings the plugin back to a working state.

	Also, writeComment() has 4 parameters yet you're passing 5 args...

	def writeComment(request, config, data, comment):
	writeComment(request, config, data, cdict, config['blog_encoding'])

	I'm pretty sure my copy of comments.py is up to date. Perhaps you have
	local changes that haven't been committed yet? Anyway, I get complaints
	if I try passing a 5th argument.

	One last note:
	AFAIK, it seems the TrackBack technical specification states that _only_
	the URL is required and all other fields are optional:

	http://www.sixapart.com/pronet/docs/trackback_spec

	meaning that: 

	if form.has_key("title") and form.has_key("excerpt") and \
               form.has_key("url") and form.has_key("blog_name"):

	could use some cleaning up. It may be the case where we only get the URL
	yet we tell the user they've given a bad request. Any thoughts?

	Using PyBlosxom has introduced me to Python and I'm really digging it.
	I'll probably do some work on this trackback plugin and send you a patch
	(unless you beat me to it ;-). I'll have to familiarize myself with both
	Python and the pyBlosxom API but neither appear to be too daunting.

	



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click