Re: issues with comments.py

Thanks, Will.

Good questions. I had thought of these, but in the interests of 
*simplicity*, decided to just change the default behavior, and not have 
an option to specify "yes" or "no" as the default.

Of course, maybe that is bad, since user's will have to make a change to 
get comments to work. However, the change is very very simple, and 
really, at least in my opinion, this makes for alot more consistent 
behavior. If we added an option in the config.py, I think this would 
just be more confusing, and more complicated, and I think, in the end, 
folks will opt for the behavior as written in the mod, so why have the 
option? One more variable to keep track of, document, etc.

Hey, it's easy enough to add something in the config - if that's what 
people want. Usually, I don't like updates which break current behavior. 
In this case, *I* am willing to make an exception to this - but are 
everyone else?

Whatever the people say, is fine by me....

Regards,
David

will guaraldi wrote:
> 
> Wow--David, you rock!
> 
> I'm in the process of factoring your changes into the comments.py 
> plugin. The only issue I have is that I'm not sure whether it should 
> default to showcomments=no or showcomments=yes (and you switch the 
> behavior with a config.py flag).
> 
> On the one hand, showing comments should be explicit and that's the 
> right thing to do.
> 
> On the other hand, if someone upgrades their comments plugin, they won't 
> have a clue why it's suddenly not showing comments on their blog.  I 
> can't tell if some or most users read the plugin documentation, but 
> we'll definitely encounter users who don't.  I'm not sure where or how 
> to notify them very very clearly that this is a big change in behavior 
> and they have to adjust accordingly.
> 
> I think I'm hedging towards doing the right thing and then plastering 
> the world with notices that we changed the behavior.  Anyone have 
> thoughts or comments on that?
> 
> /will
> 
> 
> On Fri, 27 May 2005, David Geller wrote:
> 
>>
>> Fixed comments.py to allow comments to be invoked only when specified 
>> in query string.
>>
>> The way comments.py currently works, is if there is a single entry, 
>> comments will always be invoked (comments displayed, with form, if 
>> exists). This results in somewhat inconsistent behavior - and for me, 
>> at least, was confusing.
>>
>> The *new* way, is slightly different. The default is *no* comments. 
>> Therefore, with no changes to url's, comments will *not* be displayed 
>> for single entries. To display comments, add the following query 
>> string to url: "?showcomments=yes". This typically would be in the 
>> story template, when listing the link to display comments, e.g.:
>>
>>  <a href="$base_url/$file_path?showcomments=yes" title="Leave or read 
>> comments">$num_comments Comments</a>
>>
>>
>> The changes were made to the version of comments.py in 
>> contrib-1.2.1/plugins/comments/plugins.
>>
>>
>> Regards,
>> David
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by Yahoo.
> Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
> Search APIs Find out how you can build Yahoo! directly into your own
> Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
> _______________________________________________
> pyblosxom-users mailing list
> pyblosxom-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/pyblosxom-users
> 


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005