Re: Thoughts on comments package

On Fri, 13 Feb 2004, Ted Leung wrote:
>
> On Feb 13, 2004, at 7:21 AM, will guaraldi wrote:
>
> > All of that can be done with the existing Pyblosxom framework without
> > any problems (you'd implement a renderer for the xmlrpc output).  We
> > could make it more efficient (Ted mentioned that it's kind of silly to
> > have a trackback error go all the way through the Pyblosxom pipeline)
> > by implementing a handle callback which would get called before the
> > pathinfo callback.  The handle callback would call all the functions
> > registered and ask them if they want to handle the request (i.e.
> > processing the request all the way through producing output).  If they
> > handle it, they return 1 and we're done.  We move the existing blosxom
> > processing to a handleBlosxomProcessing callback.
> >
>
> Sounds to me like you're planning to change the framework (add new
> callbacks). But I'm curious to see how it comes out.

Just one callback--and it's a handling kind of callback.  The purpose of
this is to allow plugins to handle a Pyblosxom request as they see fit
without forcing them to go down the regular blosxom handling path.

Adding the callback and adjusting the existing Pyblosxom code would
involve adding 5-10 lines in the run method in the Pyblosxom object.


> > My first blush examination is that this is easy to implement.  I was
> > planning on putting this together and taking it through its paces to
> > see how easy it is to implement.
> >
>
> I thought about this some more, and it's probably not too bad.  Before
> you do this, could you check in the current version of the xmlrpc stuff
> you are working on?

Here's my current plan:

  1. finish up xmlrpc (and blogger plugin) fixes/changes
  2. add handle callback
  3. fix xmlrpc so that it uses the handle callback instead of the
     xmlrpc.cgi
  4. write up some documentation on this


Getting there....

/will


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click