RE: comments plugin...slow?

On Tue, 18 May 2004, Blake Winton wrote:
> >
> > Ahh but the comments plugin generates a $num_comments
> > variable for every entry that gets displayed.  In order to
> > do this, it has to parse all the comments for that entry.
> > So even if you don't use the $num_comments variable, it's
> > there and the comments plugin generates it.
>
> But the comments plugin could be changed to only generate the
> data for that variable when requested, like most of the other
> plugins do...  (It won't help if you use the $num_comments
> variable, but it should be faster if you don't, and it's
> probably a good thing to do, just in case other people use
> it as the basis for new plugins.)
>
> Hey Gabor, do you know Python?  Do you want to learn?  The
> changes that need to be made are fairly easy, and come with
> a lot of samples to guide you.

It might actually be like that already--I didn't check the code.  Didn't
look like it was an on-demand sort of thing as far as I could tell.  If
this is really needed, I can add it to my list of things to do, but to be
honest, I think the general case is that people will be using
$num_comments, so it should be a back-burner post 1.0 release issue
(unless someone wants to send me a patch today).

/will


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click