About _decode_string(s, charset) in http_request.py
Damjan <[email protected]>
| Newsgroups | gmane.comp.web.quixote.user |
|---|---|
| Message-ID | <[email protected]> |
The function _decode_string(s, charset) in http_request.py improperly assumes that iso-8859-1 is the default charset. But the HTTPRequest class or an instance of that class can have a different default charset by changing the DEFAULT_CHARSET member variable. Actually its not very clear what that function tries to do, it seems that it will return a unciode object for any other charset, but it will return a byte string if the charset is 'iso-8859-1'... this seems to be very wrong... Can someone with more knowledge explain what exactly should tihs function perform??? In the meanwhile I'll remove the check for iso-8859-1 from _decode_string so that it always returns a ".decode"-ed unicode object, and see if something breaks. -- damjan | дамјан This is my jabber ID --> [email protected] <-- not my mail address!!!