Re: Patch[1] for http_response.py for quixote-2.1
Damjan <[email protected]>
| Newsgroups | gmane.comp.web.quixote.user |
|---|---|
| Message-ID | <[email protected]> |
> > This patch for Quixote-2.1/http_response.py makes the > > HTTPResponse.set_content_type method more similar to > > HTTPResponse.__init__, in that it no longer assumes that iso-8859-1 is the > > default charset. > > According to the HTTP specification, iso-8859-1 is the default > charset if the 'charset' parameter of the Context-Type header is not > provided. That is why set_content_type works the way it does. How does that matter if the user (quixote developer) changes HTTPResponse.DEFAULT_CHARSET to something else (expecting that change to be reflected everywhere)? iso-8859-1 will still be used if that's what HTTPResponse.DEFAULT_CHARSET is set to (which it does by default)! Also you can see the HTTPResponse.__init__ method just above this HTTPResponse.set_content_type method that it's does the same thing this patch does. -- damjan | дамјан This is my jabber ID --> [email protected] <-- not my mail address!!!