Re: several DAV/SSL problems with sitecopy 0.15.1

On Wed, Jun 15, 2005 at 03:20:32PM -0500, Timothee Besset wrote:
> Joe Orton wrote:
> >If you do
> >
> > $ rm .sitecopy/sitename.crt
> >
> >then sitecopy will prompt again for you to accept the certificate, and 
> >then store that cert for future invocations. If the ceriticate presented 
> >ever differs from the cached version, sitecopy fails with the errors.  
> >
> >Something better could be done here probably, but this is "fail safe", 
> >at least.
>
> I noticed that, and accepted the certificate on the initial prompt, but
> on further runs, sitecopy failed with the errors I reported. I would
> have to kill the .crt each time before I run sitecopy. So I guess the
> part where it checks against the cached version fails?

Oh, hmmm, you say you were getting ID mismatch errors?  sitecopy will 
still fail the check in that case, yeah.  This is really unnecessary, I 
suppose.  If you apply this patch, does it work?

Index: src/davdriver.c
===================================================================
--- src/davdriver.c	(revision 608)
+++ src/davdriver.c	(working copy)
@@ -208,7 +208,7 @@
 {
     ne_ssl_certificate *expected = userdata;
 
-    return failures != NE_SSL_UNTRUSTED || ne_ssl_cert_cmp(expected, cert);
+    return ne_ssl_cert_cmp(expected, cert);
 }
 
 static int init(void **session, struct site *site)

_______________________________________________
sitecopy maillist  -  [email protected]
http://dav.lyra.org/mailman/listinfo/sitecopy