Re: Fetch bug and fix

On Fri, May 12, 2006 at 01:41:38AM +0200, Miguel N wrote:
> Hi all, 
> 
> When a remote site contains more than 128 subdirectories, a lot of files
> are ignored by the fetch process. And this  files are unnecesary uploaded in 
> the next update.
> 
> The problem is: dirstack array in site_fetch() function has a fixed size,
> maximum 128 directories. So when this stack is full, new fetched directories
> cannot be added to the stack and are simply  ignored.
>   
> It's strange because the rest of functions in sites.c file correctly 
> implements a dynamic stack , but it seems someone forgot to add this feature 
> in site_fetch() function  ;)

Hi Miguel, thanks for the patch.  That would work, but there really 
needs to be a limit on the amount of memory the server can force 
sitecopy to use.  So I'd really rather just bump the size of the stack 
to something larger; say 1024 deep?  I find it pretty hard to imagine a 
site deeper than 1024 directories!

Regards,

joe
_______________________________________________
sitecopy maillist  -  [email protected]
http://dav.lyra.org/mailman/listinfo/sitecopy