Re: Working on SIM-82

[email protected]
Newsgroups gmane.comp.web.sitemesh.general
Message-ID <[email protected]>
Joseph,

I can only admire such an effort. Remember that it took us quite a while to get SiteMesh running on all different containers, and I hope that the team can agree on a common approach to container differences (writer/outputstream mess), so that we can scrap out the if Container.get() == TOMCAT once and for all.

While you're at it, the DecoratorMapper could also use a rewrite moving getNamedDecorator into getDecorator.

Let me know if I can be of any help or if you have any questions.

Cheers,
Mathias

>----- Oorspronkelijk bericht -----
>Van
: Joseph Ottinger [mailto:[email protected]]
>Verzonden
: dinsdag
, maart
 9, 2004 01:57 PM
>Aan
: [email protected]
>Onderwerp
: [Opensymphony-sitemesh] Working on SIM-82
>
>You know, part of the problem with SIM-82 is that the decorators are
>applied in a massive rat's-nest of code. Would anyone vastly object to me
>looking into ripping it all into tiny little pieces and reassembling it in
>such a way that it, you know, works?
>
>This would be a pretty fundamental rewrite. The apply decorator tag and
>the pagefilter would both be scrapped, while the configuration gets left
>alone (as do the mappers) - the response and request wrappers would be
>added to and reorganized (I know, I know, you're thinking "Request
>wrappers? There are none!" Well, there should be - and there is in
>SIM-83.) The parsers would be left alone, too - it's mainly in applying
>the decorators themselves that things get wonky.
>
>The chores would be to rewrite the core of applying the decorators - I'm
>willing to take that on, as I've been spending my free time in that stuff
>lately - and in testing to make sure everything works as expected. I think
>we can manage that, but I don't have every container handy, so there may
>be behavior I can't mirror locally.
>
>Any suggestions/advice/refusals? (I can hear them now: I'm mainly writing
>this to give you a chance to say stuff like "sitemesh is good enough, it's
>only on one main container that it's badly broken, it works for me," etc.
>See, when you say stuff like that, it means I can throw up my hands and
>ignore the problem just like everyone else, which frees me up for other
>tasks again. :)
>
>-----------------------------------------------------------------------
>Joseph B. Ottinger                             http://enigmastation.com
>IT Consultant                                    [email protected]
>Editor-in-Chief - Java Developer's Journal   [email protected]
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: IBM Linux Tutorials
>Free Linux tutorial presented by Daniel Robbins, President and CEO of
>GenToo technologies. Learn everything from fundamentals to system
>administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>_______________________________________________
>Opensymphony-sitemesh mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/opensymphony-sitemesh
>
>
>




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.