Re: Working on SIM-82

I'm a +1 on this _as long as you're willing to put in the testing  
effort_.

Sorry to be a bore on this (we'd all like SiteMesh to be better), but...

Trust me when I say that Scott has put in a s**tload of time testing  
SiteMesh on all of the different application servers we support (Orion,  
Resin, Jetty, JBoss, Tomcat, Weblogic, Websphere, SunOne, JRun) and  
we've found that developing SiteMesh is like playing whack-a-mole. Fix  
something (like i18n) on one server and it then breaks on another.

The existing test suite is pretty good, but testing is laborious  
because it really requires setting up all of these servers and  
hammering at them one by one.

At the moment the only real SiteMesh issues that I know of are the HTML  
file problems on some Tomcat versions, and the i18n problem with Resin  
+ Velocity decorators (I believe this one is a Resin bug but will check  
with Scott).

Can we maybe do this on a branch if it's going to hack at the core?  
(which I agree is a complete ball of wax at the moment - but most of  
that is because all the container specific stuff are bug fixes gained  
through much pain in the past).

Cheers,
Mike

On 10/03/2004, at 4:35 AM, Hani Suleiman wrote:

> +1 from me, even though I'm sure it entails endless unhelpful smarmy  
> comments like the below.
>
> On Mar 9, 2004, at 9:14 AM, Joseph Ottinger wrote:
>
>> Victor, THIS IS NOT THE OPENSYMPHONY WAY.
>>
>> You're supposed to say "it isn't necessary," which removes any burden  
>> of
>> work from my thin shoulders. :) Add disparaging comments at whim,  
>> etc. :)
>>
>> On Tue, 9 Mar 2004, Victor Salaman wrote:
>>
>>> +1 ... Do it mate!
>>>
>>>
>>> ----Original Message Follows----
>>> From: Joseph Ottinger <[email protected]>
>>> To: <[email protected]>
>>> Subject: [Opensymphony-sitemesh] Working on SIM-82
>>> Date: Tue, 9 Mar 2004 08:57:43 -0500 (EST)
>>>
>>> You know, part of the problem with SIM-82 is that the decorators are
>>> applied in a massive rat's-nest of code. Would anyone vastly object  
>>> to me
>>> looking into ripping it all into tiny little pieces and reassembling  
>>> it in
>>> such a way that it, you know, works?
>>>
>>> This would be a pretty fundamental rewrite. The apply decorator tag  
>>> and
>>> the pagefilter would both be scrapped, while the configuration gets  
>>> left
>>> alone (as do the mappers) - the response and request wrappers would  
>>> be
>>> added to and reorganized (I know, I know, you're thinking "Request
>>> wrappers? There are none!" Well, there should be - and there is in
>>> SIM-83.) The parsers would be left alone, too - it's mainly in  
>>> applying
>>> the decorators themselves that things get wonky.
>>>
>>> The chores would be to rewrite the core of applying the decorators -  
>>> I'm
>>> willing to take that on, as I've been spending my free time in that  
>>> stuff
>>> lately - and in testing to make sure everything works as expected. I  
>>> think
>>> we can manage that, but I don't have every container handy, so there  
>>> may
>>> be behavior I can't mirror locally.
>>>
>>> Any suggestions/advice/refusals? (I can hear them now: I'm mainly  
>>> writing
>>> this to give you a chance to say stuff like "sitemesh is good  
>>> enough, it's
>>> only on one main container that it's badly broken, it works for me,"  
>>> etc.
>>> See, when you say stuff like that, it means I can throw up my hands  
>>> and
>>> ignore the problem just like everyone else, which frees me up for  
>>> other
>>> tasks again. :)
>>>
>>> --------------------------------------------------------------------- 
>>> --
>>> Joseph B. Ottinger                              
>>> http://enigmastation.com
>>> IT Consultant                                     
>>> [email protected]
>>> Editor-in-Chief - Java Developer's Journal    
>>> [email protected]
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> This SF.Net email is sponsored by: IBM Linux Tutorials
>>> Free Linux tutorial presented by Daniel Robbins, President and CEO of
>>> GenToo technologies. Learn everything from fundamentals to system
>>> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>>> _______________________________________________
>>> Opensymphony-sitemesh mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/opensymphony-sitemesh
>>>
>>> _________________________________________________________________
>>> Tired of spam? Get advanced junk mail protection with MSN 8.
>>> http://join.msn.com/?page=features/junkmail
>>>
>>
>> ---------------------------------------------------------------------- 
>> -
>> Joseph B. Ottinger                              
>> http://enigmastation.com
>> IT Consultant                                     
>> [email protected]
>> Editor-in-Chief - Java Developer's Journal    
>> [email protected]
>>
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by: IBM Linux Tutorials
>> Free Linux tutorial presented by Daniel Robbins, President and CEO of
>> GenToo technologies. Learn everything from fundamentals to system
>> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>> _______________________________________________
>> Opensymphony-sitemesh mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/opensymphony-sitemesh
>>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> Opensymphony-sitemesh mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-sitemesh
>



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click