Re: RFC: Modernizing sources using clang-tidy

>
>
> > IMO we would be better off going the scripted way to remove the subset
> > of cases we can automate and catch the rest with manual edits and in
> review.
>
> I do not see a point of automating ourselves if there is an existing
> automation that works much better than anything we can do ourselves.
>

I agree. At least as a starting point. Poring over a patch is easier than
poring over the whole source


> > I like a few things the tool does. But so far it seems like something we
> > want to run across the code occasionally. eg as a Jenkins test job.
>
> Yes, or a Semaphore CI job, and/or on-demand. Please clarify regarding
> performance-* checks above. If we are in agreement regarding
> modernize-use-override and at least one more check, then I can start
> working on a polished proposal for those checks (at least) and the
> overall setup.
>

I'm also fine with running it manually every now and then. Our rate of
change is not such that we would introduce regressions all that often.

-- 
    Francesco

_______________________________________________
squid-dev mailing list
[email protected]
http://lists.squid-cache.org/listinfo/squid-dev