Re: RFC: make FOLLOW_X_FORWARDED_FOR unconditional

On 12/10/23 01:09, [email protected] wrote:
> Hey,
> 
> Not sure I understood exactly what the proposal is?

To remove the ./configure --disable-follow-x-forwarded-for build option. 
Leaving the feature available to everyone.

HTH
Amos


>  From Amos response I understand that it will be converted into some ACL which can be configured or not.
> Right?
> 
> Eliezer
> 
> From: squid-dev <[email protected]> On Behalf Of Francesco Chemolli
> Sent: Tuesday, October 10, 2023 19:18
> To: Squid Developers <[email protected]>
> Subject: [squid-dev] RFC: make FOLLOW_X_FORWARDED_FOR unconditional
> 
> Hi all,
>     what if we removed the configure option for FOLLOW_X_FORWARDED_FOR, and
> made it unconditionally part of Squid?
> 
> It is on by default, and it is controlled by runtime configuration, removing the compile-time option would ensure we have better testing coverage.
> 
> What do you think?
>