Re: Introducing myself to Squid Devs

--===============1147316711986748500==
Content-Type: multipart/alternative; boundary="000000000000c5c5940623b62504"

--000000000000c5c5940623b62504
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Alex,
I read your hint and made changes accordingly, it didn't go to spam this
time. I was going through the Squid Docs, on how to submit PR and do those
pre-merge self tests (Submission Checklist).

I will do the steps given in the Submission Checklist and submit a PR in a
day or two.

Thank you for helping me with getting started and joining the project.

Regards
Shailesh


On Fri, Oct 4, 2024 at 6:53=E2=80=AFPM Alex Rousskov <
[email protected]> wrote:

> On 2024-10-03 15:49, Shailesh Vashishth wrote:
>
> > I would like to contribute to the Squid Project and I have picked one
> > small task out of the ToDos  for myself.
>
>
> Hello Shailesh,
>
>      Welcome to the Project and good luck with your first task! If you
> need any help, please do not hesitate to ask on this mailing list or to
> post a draft pull request for discussion on GitHub:
> https://wiki.squid-cache.org/MergeProcedure
>
> BTW, I have also emailed you a few hints regarding the code below when
> you asked about it privately -- check your spam folder if you have not
> seen my response dated September 30, 2024...
>
>
> Cheers,
>
> Alex.
>
>
> >     *// XXX: This is absurd! TODO: For positives, "a/(b/c) > d" is "a*c
> >      > b*d".
> >     **if (expectlen < 100) {
> >     **   debugs(90, 3, "quick-abort? NO avoid FPE");
> >     **   return false;
> >     **}*
> >
> >     */_if ((curlen / (expectlen / 100)) > (Config.quickAbort.pct)) {
> >     _/**   debugs(90, 3, "quick-abort? NO past point of no return");
> >     **   return false;
> >     **}*
>
>
>
>
>
>

--000000000000c5c5940623b62504
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Alex,<br>I read your hint and made=C2=A0changes=C2=A0ac=
cordingly, it didn&#39;t go to spam this time. I was going through the Squi=
d Docs, on how to submit PR and do those pre-merge self tests (Submission C=
hecklist).<br><br>I will do the steps given in the Submission Checklist and=
 submit a PR in a day or two.<br><br>Thank you for helping me with=C2=A0get=
ting=C2=A0started and joining=C2=A0the project.<br><br>Regards<br>Shailesh<=
br><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">On Fri, Oct 4, 2024 at 6:53=E2=80=AFPM Alex Rousskov &lt;<a href=3D"=
mailto:[email protected]">[email protected]</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On=
 2024-10-03 15:49, Shailesh Vashishth wrote:<br>
<br>
&gt; I would like to contribute to the Squid Project and I have picked one =
<br>
&gt; small task out of the=C2=A0ToDos=C2=A0 for myself.<br>
<br>
<br>
Hello Shailesh,<br>
<br>
=C2=A0 =C2=A0 =C2=A0Welcome to the Project and good luck with your first ta=
sk! If you <br>
need any help, please do not hesitate to ask on this mailing list or to <br=
>
post a draft pull request for discussion on GitHub:<br>
<a href=3D"https://wiki.squid-cache.org/MergeProcedure" rel=3D"noreferrer" =
target=3D"_blank">https://wiki.squid-cache.org/MergeProcedure</a><br>
<br>
BTW, I have also emailed you a few hints regarding the code below when <br>
you asked about it privately -- check your spam folder if you have not <br>
seen my response dated September 30, 2024...<br>
<br>
<br>
Cheers,<br>
<br>
Alex.<br>
<br>
<br>
&gt;=C2=A0 =C2=A0 =C2=A0*// XXX: This is absurd! TODO: For positives, &quot=
;a/(b/c) &gt; d&quot; is &quot;a*c<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; b*d&quot;.<br>
&gt;=C2=A0 =C2=A0 =C2=A0**if (expectlen &lt; 100) {<br>
&gt;=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0debugs(90, 3, &quot;quick-abort? NO =
avoid FPE&quot;);<br>
&gt;=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0return false;<br>
&gt;=C2=A0 =C2=A0 =C2=A0**}* <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0*/_if ((curlen / (expectlen / 100)) &gt; (Config.qu=
ickAbort.pct)) {<br>
&gt;=C2=A0 =C2=A0 =C2=A0_/**=C2=A0 =C2=A0debugs(90, 3, &quot;quick-abort? N=
O past point of no return&quot;);<br>
&gt;=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0return false;<br>
&gt;=C2=A0 =C2=A0 =C2=A0**}*<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div>

--000000000000c5c5940623b62504--

--===============1147316711986748500==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
squid-dev mailing list
[email protected]
https://lists.squid-cache.org/listinfo/squid-dev

--===============1147316711986748500==--