Re: Introducing myself to Squid Devs
Shailesh Vashishth <[email protected]> Sun, 27 Oct 2024 19:45:19 +0530
| Newsgroups | gmane.comp.web.squid.devel |
|---|---|
| Message-ID | <CABHxcG=Hv5Mep+dpEgiea3YmPi9egrPjS_T6CA6uPHd5XQ8XbA@mail.gmail.com> |
--===============2258565944910507562==
Content-Type: multipart/alternative; boundary="0000000000001cadba062575fcbb"
--0000000000001cadba062575fcbb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi
There is another very small ToDo that I would like take up --
This is also a very simple and small change -- replacing *Io with
Store::IoStatus *and removing the *using *statement
Address the following TODO:
/* TODO: Remove this change-minimizing hack */
using Io =3D Store::IoStatus;
static constexpr Io ioUndecided =3D Store::ioUndecided;
static constexpr Io ioReading =3D Store::ioReading;
static constexpr Io ioWriting =3D Store::ioWriting;
static constexpr Io ioDone =3D Store::ioDone;
Regards
Shailesh
On Sat, Oct 26, 2024 at 12:54=E2=80=AFAM Shailesh Vashishth <shavashishth@g=
mail.com>
wrote:
> Hi
> I would like to take up another Todo item that is listed here --
> https://github.com/measurement-factory/squid-notes/blob/start/todos.md
>
> I would like to pick this item : I think this requires very small change,
> where we just print *name_len *on the *stdout *using the custom function
> for printing debug logs.
>
>
> - Address the following TODO by adding any using Raw::upto(n) which
> will limit the size value of passed to PrintHex() and write() inside
> Raw::print(). That value is currently size_.
>
> if (name_len > 65534) {
>> /* String must be LESS THAN 64K and it adds a terminating NULL */
>> // TODO: update this to show proper name_len in Raw markup, but not prin=
t
>> all that
>> debugs(55, 2, "ignoring huge header field (" << Raw("field_start",
>> field_start, 100) << "...)");
>>
>
>
> My current PR (*https://github.com/squid-cache/squid/pull/1921
> <https://github.com/squid-cache/squid/pull/1921>*) has succeeded all
> Pipeline stages, only your approval is remaining.
>
> Regards
> Shailesh
>
> On Wed, Oct 23, 2024 at 12:30=E2=80=AFAM Shailesh Vashishth <
> [email protected]> wrote:
>
>> Hi
>> I have made a change to a math expression in store_client.cc and raised
>> the following pull request.
>>
>> if (curlen > expectlen*(Config.quickAbort.pct/100.0)) {
>> debugs(90, 3, "quick-abort? NO past point of no return");
>> return false;
>> }
>>
>> I have also ran the test-build.sh (suggested in Submissions Checklist)
>> and it passed all test cases.
>>
>> Please review the following pull request -
>> https://github.com/squid-cache/squid/pull/1921
>>
>> Regards
>> Shailesh
>>
>> On Sat, Oct 5, 2024 at 1:27=E2=80=AFPM Shailesh Vashishth <shavashishth@=
gmail.com>
>> wrote:
>>
>>> Hi Alex,
>>> I read your hint and made changes accordingly, it didn't go to spam thi=
s
>>> time. I was going through the Squid Docs, on how to submit PR and do th=
ose
>>> pre-merge self tests (Submission Checklist).
>>>
>>> I will do the steps given in the Submission Checklist and submit a PR i=
n
>>> a day or two.
>>>
>>> Thank you for helping me with getting started and joining the project.
>>>
>>> Regards
>>> Shailesh
>>>
>>>
>>> On Fri, Oct 4, 2024 at 6:53=E2=80=AFPM Alex Rousskov <
>>> [email protected]> wrote:
>>>
>>>> On 2024-10-03 15:49, Shailesh Vashishth wrote:
>>>>
>>>> > I would like to contribute to the Squid Project and I have picked on=
e
>>>> > small task out of the ToDos for myself.
>>>>
>>>>
>>>> Hello Shailesh,
>>>>
>>>> Welcome to the Project and good luck with your first task! If you
>>>> need any help, please do not hesitate to ask on this mailing list or t=
o
>>>> post a draft pull request for discussion on GitHub:
>>>> https://wiki.squid-cache.org/MergeProcedure
>>>>
>>>> BTW, I have also emailed you a few hints regarding the code below when
>>>> you asked about it privately -- check your spam folder if you have not
>>>> seen my response dated September 30, 2024...
>>>>
>>>>
>>>> Cheers,
>>>>
>>>> Alex.
>>>>
>>>>
>>>> > *// XXX: This is absurd! TODO: For positives, "a/(b/c) > d" is
>>>> "a*c
>>>> > > b*d".
>>>> > **if (expectlen < 100) {
>>>> > ** debugs(90, 3, "quick-abort? NO avoid FPE");
>>>> > ** return false;
>>>> > **}*
>>>> >
>>>> > */_if ((curlen / (expectlen / 100)) > (Config.quickAbort.pct)) {
>>>> > _/** debugs(90, 3, "quick-abort? NO past point of no return");
>>>> > ** return false;
>>>> > **}*
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
--0000000000001cadba062575fcbb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Hi=C2=A0<br>There is another very small ToDo that I would =
like take up --=C2=A0<br><br>This is also a very simple and small change --=
replacing <b><span style=3D"background-color:rgb(255,255,0)">Io with Store=
::IoStatus</span> </b>and removing the <b><span style=3D"background-color:r=
gb(255,255,0)">using</span> </b>statement<br><div><br></div><div><div style=
=3D"color:rgb(204,204,204);background-color:rgb(31,31,31);font-family:Menlo=
,Monaco,"Courier New",monospace;font-size:12px;line-height:18px;w=
hite-space:pre"><div>Address the following TODO:</div><div><span style=3D"c=
olor:rgb(106,153,85)">/* TODO: Remove this change-minimizing hack */</span>=
</div><div><span style=3D"color:rgb(197,134,192)">using</span> <span style=
=3D"color:rgb(78,201,176)">Io</span> <span style=3D"color:rgb(212,212,212)"=
>=3D</span> <span style=3D"color:rgb(78,201,176)">Store</span>::<span style=
=3D"color:rgb(78,201,176)">IoStatus</span>;</div><div><span style=3D"color:=
rgb(86,156,214)">static</span> <span style=3D"color:rgb(86,156,214)">conste=
xpr</span> Io ioUndecided <span style=3D"color:rgb(212,212,212)">=3D</span>=
<span style=3D"color:rgb(78,201,176)">Store</span>::ioUndecided;</div><div=
><span style=3D"color:rgb(86,156,214)">static</span> <span style=3D"color:r=
gb(86,156,214)">constexpr</span> Io ioReading <span style=3D"color:rgb(212,=
212,212)">=3D</span> <span style=3D"color:rgb(78,201,176)">Store</span>::io=
Reading;</div><div><span style=3D"color:rgb(86,156,214)">static</span> <spa=
n style=3D"color:rgb(86,156,214)">constexpr</span> Io ioWriting <span style=
=3D"color:rgb(212,212,212)">=3D</span> <span style=3D"color:rgb(78,201,176)=
">Store</span>::ioWriting;</div><div><span style=3D"color:rgb(86,156,214)">=
static</span> <span style=3D"color:rgb(86,156,214)">constexpr</span> Io ioD=
one <span style=3D"color:rgb(212,212,212)">=3D</span> <span style=3D"color:=
rgb(78,201,176)">Store</span>::ioDone;</div></div></div><div><br></div><div=
><br></div><div>Regards<br>Shailesh</div></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Oct 26, 2024 at 12:54=E2=
=80=AFAM Shailesh Vashishth <<a href=3D"mailto:[email protected]">s=
[email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr">Hi<br>I would like to take up another=
Todo item that is listed here --=C2=A0<a href=3D"https://github.com/measur=
ement-factory/squid-notes/blob/start/todos.md" target=3D"_blank">https://gi=
thub.com/measurement-factory/squid-notes/blob/start/todos.md</a><div><br></=
div><div>I would like to pick this item : I think this requires very small =
change, where we just print <b>name_len </b>on the <b>stdout </b>using the =
custom function for printing debug logs.<br><br><ul dir=3D"auto" style=3D"b=
ox-sizing:border-box;padding-left:2em;margin-top:0px;color:rgb(240,246,252)=
;font-family:-apple-system,"system-ui","Segoe UI","=
;Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji",&=
quot;Segoe UI Emoji";background-color:rgb(13,17,23)"><li style=3D"box-=
sizing:border-box">Address the following TODO by adding any using Raw::upto=
(n) which will limit the size value of passed to PrintHex() and write() ins=
ide Raw::print(). That value is currently size_.</li></ul><div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div style=3D"color:rgb(204,204,204);=
background-color:rgb(31,31,31);font-family:Menlo,Monaco,"Courier New&q=
uot;,monospace;font-size:12px;line-height:18px;white-space:pre-wrap"><div><=
span style=3D"color:rgb(197,134,192)">if</span> (name_len <span style=3D"co=
lor:rgb(212,212,212)">></span> <span style=3D"color:rgb(181,206,168)">65=
534</span>) {</div><div><span style=3D"color:rgb(106,153,85)"> /* String=
must be LESS THAN 64K and it adds a terminating NULL */</span></div><div><=
span style=3D"color:rgb(106,153,85)"> // TODO: update this to show prope=
r name_len in Raw markup, but not print all that</span></div><div> <span=
style=3D"color:rgb(220,220,170)">debugs</span>(<span style=3D"color:rgb(18=
1,206,168)">55</span>, <span style=3D"color:rgb(181,206,168)">2</span>, <sp=
an style=3D"color:rgb(206,145,120)">"ignoring huge header field ("=
;</span> <span style=3D"color:rgb(212,212,212)"><<</span> <span style=
=3D"color:rgb(220,220,170)">Raw</span>(<span style=3D"color:rgb(206,145,120=
)">"field_start"</span>, field_start, <span style=3D"color:rgb(18=
1,206,168)">100</span>) <span style=3D"color:rgb(212,212,212)"><<</sp=
an> <span style=3D"color:rgb(206,145,120)">"...)"</span>);</div><=
/div></blockquote><br><br>My current PR (<u><a href=3D"https://github.com/s=
quid-cache/squid/pull/1921" target=3D"_blank">https://github.com/squid-cach=
e/squid/pull/1921</a></u>) has succeeded all Pipeline stages, only your app=
roval is remaining.<br><br>Regards<br>Shailesh<br></div></div></div><br><di=
v class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 2=
3, 2024 at 12:30=E2=80=AFAM Shailesh Vashishth <<a href=3D"mailto:shavas=
[email protected]" target=3D"_blank">[email protected]</a>> wrote:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
<div dir=3D"ltr">Hi<br>I have made a change to a math expression in store_c=
lient.cc and raised the following pull request.<br><br><div style=3D"color:=
rgb(204,204,204);background-color:rgb(31,31,31);font-family:Menlo,Monaco,&q=
uot;Courier New",monospace;font-size:12px;line-height:18px;white-space=
:pre-wrap"><div><span style=3D"color:rgb(197,134,192)">if</span> (<span sty=
le=3D"color:rgb(156,220,254)">curlen</span> <span style=3D"color:rgb(212,21=
2,212)">></span> <span style=3D"color:rgb(156,220,254)">expectlen</span>=
<span style=3D"color:rgb(212,212,212)">*</span>(<span style=3D"color:rgb(15=
6,220,254)">Config</span>.<span style=3D"color:rgb(156,220,254)">quickAbort=
</span>.<span style=3D"color:rgb(156,220,254)">pct</span><span style=3D"col=
or:rgb(212,212,212)">/</span><span style=3D"color:rgb(181,206,168)">100.0</=
span>)) {</div><div> <span style=3D"color:rgb(86,156,214)">debugs</s=
pan>(<span style=3D"color:rgb(181,206,168)">90</span>, <span style=3D"color=
:rgb(181,206,168)">3</span>, <span style=3D"color:rgb(206,145,120)">"q=
uick-abort? NO past point of no return"</span>);</div><div> <sp=
an style=3D"color:rgb(197,134,192)">return</span> <span style=3D"color:rgb(=
86,156,214)">false</span>;</div><div> }</div></div><br>I have also ran t=
he test-build.sh (suggested in Submissions Checklist) and it passed all tes=
t cases.=C2=A0<br><br>Please review the following pull request -=C2=A0<a hr=
ef=3D"https://github.com/squid-cache/squid/pull/1921" target=3D"_blank">htt=
ps://github.com/squid-cache/squid/pull/1921</a><br><br>Regards<br>Shailesh<=
br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_att=
r">On Sat, Oct 5, 2024 at 1:27=E2=80=AFPM Shailesh Vashishth <<a href=3D=
"mailto:[email protected]" target=3D"_blank">[email protected]</a=
>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di=
v dir=3D"ltr">Hi Alex,<br>I read your hint and made=C2=A0changes=C2=A0accor=
dingly, it didn't go to spam this time. I was going through the Squid D=
ocs, on how to submit PR and do those pre-merge self tests (Submission Chec=
klist).<br><br>I will do the steps given in the Submission Checklist and su=
bmit a PR in a day or two.<br><br>Thank you for helping me with=C2=A0gettin=
g=C2=A0started and joining=C2=A0the project.<br><br>Regards<br>Shailesh<br>=
<br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_at=
tr">On Fri, Oct 4, 2024 at 6:53=E2=80=AFPM Alex Rousskov <<a href=3D"mai=
lto:[email protected]" target=3D"_blank">rousskov@measuremen=
t-factory.com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">On 2024-10-03 15:49, Shailesh Vashishth wrote:<br>
<br>
> I would like to contribute to the Squid Project and I have picked one =
<br>
> small task out of the=C2=A0ToDos=C2=A0 for myself.<br>
<br>
<br>
Hello Shailesh,<br>
<br>
=C2=A0 =C2=A0 =C2=A0Welcome to the Project and good luck with your first ta=
sk! If you <br>
need any help, please do not hesitate to ask on this mailing list or to <br=
>
post a draft pull request for discussion on GitHub:<br>
<a href=3D"https://wiki.squid-cache.org/MergeProcedure" rel=3D"noreferrer" =
target=3D"_blank">https://wiki.squid-cache.org/MergeProcedure</a><br>
<br>
BTW, I have also emailed you a few hints regarding the code below when <br>
you asked about it privately -- check your spam folder if you have not <br>
seen my response dated September 30, 2024...<br>
<br>
<br>
Cheers,<br>
<br>
Alex.<br>
<br>
<br>
>=C2=A0 =C2=A0 =C2=A0*// XXX: This is absurd! TODO: For positives, "=
;a/(b/c) > d" is "a*c<br>
>=C2=A0 =C2=A0 =C2=A0 > b*d".<br>
>=C2=A0 =C2=A0 =C2=A0**if (expectlen < 100) {<br>
>=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0debugs(90, 3, "quick-abort? NO =
avoid FPE");<br>
>=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0return false;<br>
>=C2=A0 =C2=A0 =C2=A0**}* <br>
> <br>
>=C2=A0 =C2=A0 =C2=A0*/_if ((curlen / (expectlen / 100)) > (Config.qu=
ickAbort.pct)) {<br>
>=C2=A0 =C2=A0 =C2=A0_/**=C2=A0 =C2=A0debugs(90, 3, "quick-abort? N=
O past point of no return");<br>
>=C2=A0 =C2=A0 =C2=A0**=C2=A0 =C2=A0return false;<br>
>=C2=A0 =C2=A0 =C2=A0**}*<br>
<br>
<br>
<br>
<br>
<br>
</blockquote></div>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>
--0000000000001cadba062575fcbb--
--===============2258565944910507562==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
squid-dev mailing list
[email protected]
https://lists.squid-cache.org/listinfo/squid-dev
--===============2258565944910507562==--